Skip to content

feat(ui): do not use thumbnail images as fallbacks #8529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat(ui): do not use thumbnail images as fallbacks #8529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion invokeai/frontend/web/src/features/dnd/DndImage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ export const DndImage = memo(
role="button"
ref={ref}
src={asThumbnail ? imageDTO.thumbnail_url : imageDTO.image_url}
fallbackSrc={asThumbnail ? undefined : imageDTO.thumbnail_url}
width={imageDTO.width}
height={imageDTO.height}
sx={sx}
Expand Down
2 changes: 0 additions & 2 deletions invokeai/frontend/web/src/features/gallery/components/ImageViewer/ImageComparisonHover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ export const ImageComparisonHover = memo(({ firstImage, secondImage, rect }: Com
<Image
id="image-comparison-hover-first-image"
src={firstImage.image_url}
fallbackSrc={firstImage.thumbnail_url}
crossOrigin={crossOrigin}
w={fittedDims.width}
h={fittedDims.height}
Expand Down Expand Up @@ -93,7 +92,6 @@ export const ImageComparisonHover = memo(({ firstImage, secondImage, rect }: Com
position="relative"
id="image-comparison-hover-second-image"
src={secondImage.image_url}
fallbackSrc={secondImage.thumbnail_url}
crossOrigin={crossOrigin}
w={compareImageDims.width}
h={compareImageDims.height}
Expand Down
1 change: 0 additions & 1 deletion ...ai/frontend/web/src/features/gallery/components/ImageViewer/ImageComparisonSideBySide.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ const SideBySideImage = memo(({ imageDTO, type }: { imageDTO: ImageDTO; type: 'f
maxW="full"
maxH="full"
src={imageDTO.image_url}
fallbackSrc={imageDTO.thumbnail_url}
crossOrigin={crossOrigin}
objectFit="contain"
borderRadius="base"
Expand Down
2 changes: 0 additions & 2 deletions invokeai/frontend/web/src/features/gallery/components/ImageViewer/ImageComparisonSlider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ export const ImageComparisonSlider = memo(({ firstImage, secondImage, rect }: Co
position="relative"
id="image-comparison-second-image"
src={secondImage.image_url}
fallbackSrc={secondImage.thumbnail_url}
crossOrigin={crossOrigin}
w={compareImageDims.width}
h={compareImageDims.height}
Expand All @@ -157,7 +156,6 @@ export const ImageComparisonSlider = memo(({ firstImage, secondImage, rect }: Co
<Image
id="image-comparison-first-image"
src={firstImage.image_url}
fallbackSrc={firstImage.thumbnail_url}
crossOrigin={crossOrigin}
w={fittedDims.width}
h={fittedDims.height}
Expand Down