New array based git API command for webui #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isc-pbarton
requested changes
Jul 30, 2024
There was a problem hiding this comment.
Committing multiple files at once doesn't work properly with the new endpoint. I get the following error:
error: pathspec 'cls/pbarton2/nesdsaf.cls cls/pbarton2/dfsdf.cls' did not match any file(s) known to git
The raw request sent to the new git-command endpoint is:
{"command":["add","cls/pbarton2/nesdsaf.cls cls/pbarton2/dfsdf.cls"]}
The files probably need to be split into separate args.
isc-pbarton
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #437, #433
all commits and amends from webui now run through the "/git-command" endpoint