Skip to content

fix(publish): Status job detail chrome uses the message catalog (#4808) - #4819

Merged
natechadwick-intsof merged 3 commits into
mainfrom
fix/issue-4808-status-job-detail-i18n
Sep 24, 2026
Merged

natechadwick-intsof merged 3 commits into
mainfrom
fix/issue-4808-status-job-detail-i18n

Conversation

@natechadwick-intsof

@natechadwick-intsof natechadwick-intsof commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

PublishingShell Status job detail no longer hardcodes Job details, Job ID, Edition, or Error. Those labels go through message(MSG.PUBLISH.STATUS_DETAIL.*). Job ID and Error reuse existing CmsUi.tmx tuids. Job details and Edition are new en-us catalog entries only (no multi-locale backfill).

Parent: #4531. Fixes #4808.

Operator: Grok: night-issue-prs (model grok-4.6)

Test plan

  1. Open Publishing → Status, open a job row, and confirm the detail heading and Job ID / Edition / Error labels render (English default).
  2. Close the panel and confirm the job is not stopped.
  3. Surface Playwright: modules/perc-qa-automation/frontend npm run test:surface -- --path tests/publishing/statusJobDetail.spec.js against QA H2.

Checklist

  • Product documentation — N/A: no operator-facing label list in product-docs/ documents these four strings; behavior of the panel is unchanged.
  • Unit / module tests — Vitest asserts the four chrome labels; Playwright surface asserts the same.
  • WebUI + Playwright — modules/perc-qa-automation/frontend/tests/publishing/statusJobDetail.spec.js (1 passed).
  • Build gates — standalone clean install for modules/perc-i18n, WebUI, modules/perc-qa-automation.
  • Cross-platform — N/A (no path/file I/O).

Build evidence

  • modules_built: modules/perc-i18n, WebUI, modules/perc-qa-automation
  • downstream_checked: none (no public/protected signature or final/sealed type change)
  • cd modules/perc-i18n && rtk mvn clean install — BUILD SUCCESS, Tests run: 33, Failures: 0
  • cd WebUI && JAVA_HOME=/usr/lib/jvm/java-21-openjdk rtk mvn clean install — BUILD SUCCESS, Surefire Tests run: 69, Failures: 0; Vitest Test Files 537 passed, Tests 4947 passed
  • cd modules/perc-qa-automation && rtk mvn clean install — BUILD SUCCESS, No tests to run

UI proof (C5)

  • python3 docker/scripts/perc-devctl.py qa-up — TEST_CMS_URL=http://127.0.0.1:9993, container perc-matrix-cms-h2, qa-health RESULT:OK HEALTH:healthy
  • Deployed perc-modern-ui.js/.css plus hashed assets, perc-i18n-8.2.0-SNAPSHOT.jar into WEB-INF/lib, and rxconfig/i18n/CmsUi.tmx; restarted Jetty with StopJetty.sh/StartJetty.sh (not docker restart); qa-health RESULT:OK again
  • npm run test:surface -- --path tests/publishing/statusJobDetail.spec.js — 1 passed
  • console-clean=yes (spec asserts no pageerror/console error)
  • server.log-clean=yes (no ERROR/FATAL in the test window)
  • python3 docker/scripts/perc-devctl.py qa-down — container removed

Pre-push local code review

Summary

Machine analysis found 0 finding(s), 0 bug(s).

Scope

  • Base: origin/main
  • Head: HEAD
  • Files: 5 analyzed
  • Persona: erlang 0.1.1
  • Persona source: /home/nate/.local/share/mkd/agents/erlang

Recommendation

approve

Gate

  • Blocking bugs: 0
  • May commit/push: yes

Issues

No issues.

Route Status job detail heading, Job ID, Edition, and Error through
message() so those labels are not hardcoded English.

> Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs-erlang.
@natechadwick-intsof

Copy link
Copy Markdown
Collaborator Author

LGTM. Erlang (persona 0.1.1) mkd-code-review: in-diff blocking bugs 0. May commit/push: yes. Same-login APPROVE was rejected; merging by policy.

Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs-erlang.

@natechadwick-intsof
natechadwick-intsof merged commit 2c49441 into main Sep 24, 2026
5 checks passed
@natechadwick-intsof
natechadwick-intsof deleted the fix/issue-4808-status-job-detail-i18n branch September 24, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model:grok-4.6 Session model grok-4.6 operator:grok Changes authored by Grok operator:night-issue-prs night-issue-prs workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

issue 4531 slice 29: PublishingShell job detail chrome uses message catalog

1 participant