Repository navigation
fix(publish): Status job detail chrome uses the message catalog (#4808) - #4819
Merged
Merged
Conversation
Route Status job detail heading, Job ID, Edition, and Error through message() so those labels are not hardcoded English. > Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs-erlang.
Collaborator
Author
|
LGTM. Erlang (persona 0.1.1) mkd-code-review: in-diff blocking bugs 0. May commit/push: yes. Same-login APPROVE was rejected; merging by policy.
|
natechadwick-intsof
deleted the
fix/issue-4808-status-job-detail-i18n
branch
September 24, 2026 13:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PublishingShell Status job detail no longer hardcodes
Job details,Job ID,Edition, orError. Those labels go throughmessage(MSG.PUBLISH.STATUS_DETAIL.*). Job ID and Error reuse existingCmsUi.tmxtuids. Job details and Edition are new en-us catalog entries only (no multi-locale backfill).Parent: #4531. Fixes #4808.
Operator: Grok: night-issue-prs (model grok-4.6)
Test plan
modules/perc-qa-automation/frontendnpm run test:surface -- --path tests/publishing/statusJobDetail.spec.jsagainst QA H2.Checklist
product-docs/documents these four strings; behavior of the panel is unchanged.modules/perc-qa-automation/frontend/tests/publishing/statusJobDetail.spec.js(1 passed).modules/perc-i18n,WebUI,modules/perc-qa-automation.Build evidence
cd modules/perc-i18n && rtk mvn clean install— BUILD SUCCESS, Tests run: 33, Failures: 0cd WebUI && JAVA_HOME=/usr/lib/jvm/java-21-openjdk rtk mvn clean install— BUILD SUCCESS, Surefire Tests run: 69, Failures: 0; Vitest Test Files 537 passed, Tests 4947 passedcd modules/perc-qa-automation && rtk mvn clean install— BUILD SUCCESS, No tests to runUI proof (C5)
python3 docker/scripts/perc-devctl.py qa-up— TEST_CMS_URL=http://127.0.0.1:9993, container perc-matrix-cms-h2, qa-health RESULT:OK HEALTH:healthyperc-modern-ui.js/.cssplus hashed assets,perc-i18n-8.2.0-SNAPSHOT.jarintoWEB-INF/lib, andrxconfig/i18n/CmsUi.tmx; restarted Jetty with StopJetty.sh/StartJetty.sh (not docker restart); qa-health RESULT:OK againnpm run test:surface -- --path tests/publishing/statusJobDetail.spec.js— 1 passedpython3 docker/scripts/perc-devctl.py qa-down— container removedPre-push local code review
Summary
Machine analysis found 0 finding(s), 0 bug(s).
Scope
Recommendation
approve
Gate
Issues
No issues.