Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions WebUI/src/main/ts/i18n/message.ts
Original file line number Diff line number Diff line change
Expand Up @@ -642,6 +642,12 @@ GADGET_DESC_DASHBOARD_CONFIG:
},
},
},
STATUS_DETAIL: {
HEADING: "perc.ui.publish.modern@Job details",
JOB_ID: "perc.ui.publish.title@Job ID",
EDITION: "perc.ui.publish.modern@Edition",
ERROR: "perc.ui.publish.title@Error",
},
LOGS_DETAILS: {
JOB_ID: "perc.ui.publish.title@Job ID",
FILTER_ITEMS: "perc.ui.publish.title@Filter Items",
Expand Down
16 changes: 12 additions & 4 deletions WebUI/src/main/ts/publishing/components/StatusJobDetailPanel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@ export function StatusJobDetailPanel({
return (
<div data-testid="publish-status-job-detail" style={{ marginTop: 16 }}>
<div style={toolbarStyle}>
<h3 style={{ margin: 0, fontSize: "1rem" }}>Job details</h3>
<h3 style={{ margin: 0, fontSize: "1rem" }} data-testid="publish-status-detail-heading">
{message(MSG.PUBLISH.STATUS_DETAIL.HEADING)}
</h3>
<button
type="button"
style={buttonStyle}
Expand All @@ -51,15 +53,19 @@ export function StatusJobDetailPanel({
</button>
</div>
<dl style={{ fontSize: "0.9rem", margin: 0 }}>
<dt style={labelStyle}>Job ID</dt>
<dt style={labelStyle} data-testid="publish-status-detail-job-id-label">
{message(MSG.PUBLISH.STATUS_DETAIL.JOB_ID)}
</dt>
<dd style={valueStyle} data-testid="publish-status-detail-job-id">
{detail.jobId}
</dd>
<dt style={labelStyle}>{message(MSG.PUBLISH_SECTION_SITES)}</dt>
<dd style={valueStyle} data-testid="publish-status-detail-site">
{detail.site}
</dd>
<dt style={labelStyle}>Edition</dt>
<dt style={labelStyle} data-testid="publish-status-detail-edition-label">
{message(MSG.PUBLISH.STATUS_DETAIL.EDITION)}
</dt>
<dd style={valueStyle} data-testid="publish-status-detail-edition">
{detail.editionName}
</dd>
Expand All @@ -69,7 +75,9 @@ export function StatusJobDetailPanel({
</dd>
{detail.showError && (
<>
<dt style={labelStyle}>Error</dt>
<dt style={labelStyle} data-testid="publish-status-detail-error-label">
{message(MSG.PUBLISH.STATUS_DETAIL.ERROR)}
</dt>
<dd style={valueStyle} data-testid="publish-status-detail-error">
{detail.errorText}
</dd>
Expand Down
12 changes: 12 additions & 0 deletions WebUI/src/test/ts/publishing/statusJobDetailPanel.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,18 @@ describe("StatusSection job detail (#4789)", () => {
expect(screen.getByTestId("publish-status-detail-error").textContent).toBe(
"disk full",
);
expect(screen.getByTestId("publish-status-detail-heading").textContent).toBe(
"Job details",
);
expect(
screen.getByTestId("publish-status-detail-job-id-label").textContent,
).toBe("Job ID");
expect(
screen.getByTestId("publish-status-detail-edition-label").textContent,
).toBe("Edition");
expect(
screen.getByTestId("publish-status-detail-error-label").textContent,
).toBe("Error");

fireEvent.click(screen.getByTestId("publish-status-job-detail-close"));
expect(screen.queryByTestId("publish-status-job-detail")).toBeNull();
Expand Down
30 changes: 30 additions & 0 deletions docs/ai-generated/code-reviews/pr-4819-erlang.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
<!--
Copyright (c) 2026 Intersoft Data Labs, Inc.
Licensed under the Apache License, Version 2.0.
-->

## Summary

Machine analysis found **0** finding(s), **0** bug(s).

## Scope

- Base: origin/main
- Head: HEAD
- Files: 5 analyzed
- Persona: erlang 0.1.1
- Persona source: /home/nate/.local/share/mkd/agents/erlang

## Recommendation

approve

## Gate

- Blocking bugs: 0
- May commit/push: yes

## Issues

_No issues._

7 changes: 7 additions & 0 deletions modules/perc-i18n/src/main/resources/i18n/CmsUi.tmx
Original file line number Diff line number Diff line change
Expand Up @@ -27527,6 +27527,13 @@ Osparade ändringar av '{1}' kan gå förlorade.</seg></tuv></tu>
<tu tuid="perc.ui.architecture.modern@Enter a valid URL (for example https://example.com or /path)">
<tuv xml:lang="en-us"><seg>Enter a valid URL (for example https://example.com or /path)</seg></tuv>
<tuv xml:lang="hi"><seg>एक मान्य URL दर्ज करें (उदाहरण के लिए https://example.com या /path)</seg></tuv><tuv xml:lang="bn"><seg>একটি বৈধ URL লিখুন (উদাহরণস্বরূপ https://example.com বা /path)</seg></tuv><tuv xml:lang="te"><seg>చెల్లుబాటు అయ్యే URLని నమోదు చేయండి (ఉదాహరణకు https://example.com లేదా /path)</seg></tuv><tuv xml:lang="tr"><seg>Geçerli bir URL girin (örneğin https://example.com veya /path)</seg></tuv><tuv xml:lang="es"><seg>Ingrese una URL válida (por ejemplo https://example.com o /ruta)</seg></tuv><tuv xml:lang="fr"><seg>Saisissez une URL valide (par exemple https://example.com ou /path)</seg></tuv><tuv xml:lang="de"><seg>Geben Sie eine gültige URL ein (zum Beispiel https://example.com oder /path)</seg></tuv><tuv xml:lang="zh-cn"><seg>输入有效的 URL(例如 https://example.com 或 /path)</seg></tuv><tuv xml:lang="ar"><seg>أدخل عنوان URL صالحًا (على سبيل المثال https://example.com أو /path)</seg></tuv><tuv xml:lang="he"><seg>הזן כתובת אתר חוקית (לדוגמה https://example.com או /path)</seg></tuv><tuv xml:lang="it"><seg>Inserisci un URL valido (ad esempio https://example.com o /percorso)</seg></tuv><tuv xml:lang="ja-jp"><seg>有効な URL (例: https://example.com または /path) を入力します。</seg></tuv><tuv xml:lang="nb"><seg>Skriv inn en gyldig URL (for eksempel https://example.com eller /path)</seg></tuv><tuv xml:lang="nl"><seg>Voer een geldige URL in (bijvoorbeeld https://example.com of /path)</seg></tuv><tuv xml:lang="pl"><seg>Wprowadź prawidłowy adres URL (na przykład https://example.com lub /path)</seg></tuv><tuv xml:lang="pt"><seg>Insira um URL válido (por exemplo https://example.com ou /path)</seg></tuv><tuv xml:lang="ru"><seg>Введите действительный URL-адрес (например, https://example.com или /path).</seg></tuv><tuv xml:lang="sv"><seg>Ange en giltig webbadress (till exempel https://example.com eller /sökväg)</seg></tuv><tuv xml:lang="zh-tw"><seg>输入有效的 URL(例如 https://example.com 或 /path)</seg></tuv><tuv xml:lang="uk"><seg>Введіть дійсну URL-адресу (наприклад, https://example.com або /path)</seg></tuv></tu>
<!-- #4808: Status job-detail chrome. en-us only; Job ID and Error reuse existing tuids. -->
<tu tuid="perc.ui.publish.modern@Job details">
<tuv xml:lang="en-us"><seg>Job details</seg></tuv>
</tu>
<tu tuid="perc.ui.publish.modern@Edition">
<tuv xml:lang="en-us"><seg>Edition</seg></tuv>
</tu>
<!-- #3217: tooltip tuid is @Site navigation (MSG.NAV_ARCHITECTURE_TITLE). -->
<tu tuid="perc.ui.architecture.modern@Site navigation">
<tuv xml:lang="en-us"><seg>Site navigation</seg></tuv>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,18 @@ test.describe("PublishingShell Status job detail (#4789)", () => {
await expect(page.getByTestId("publish-status-detail-error")).toHaveText(
"disk full",
);
await expect(page.getByTestId("publish-status-detail-heading")).toHaveText(
"Job details",
);
await expect(
page.getByTestId("publish-status-detail-job-id-label"),
).toHaveText("Job ID");
await expect(
page.getByTestId("publish-status-detail-edition-label"),
).toHaveText("Edition");
await expect(
page.getByTestId("publish-status-detail-error-label"),
).toHaveText("Error");

await page.getByTestId("publish-status-job-detail-close").click();
await expect(page.getByTestId("publish-status-job-detail")).toHaveCount(0);
Expand Down
Loading