Repository navigation
feat(editor): move the open item to another folder (#4774) - #4781
Conversation
|
LGTM. Independent Erlang pass (did not author): mkd-code-review 0.1.18, pack percussion, gate advisory, 0 bugs. Persona: erlang 0.1.1. Persona source: ~/.local/share/mkd/agents/erlang. Editor move posts /rest/folders/move/item and does not treat cancel, view/promote, same-folder, or HTTP 403/404/409 as success. Full CLI report is in the PR body and docs/ai-generated/code-reviews/pr-4781-erlang.md (2a19e5a). GitHub rejected same-login APPROVE.
|
Edit mode can move the open item with POST /rest/folders/move/item and stay on the same content id. Cancel, view mode, and HTTP 403/404/409 do not count as a successful move. > Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs-erlang.
2a19e5a to
7c74d56
Compare
|
Rebased onto
|
Summary
Parent: #4532. Slice #4774.
Edit mode on the React EditorHost can Move to folder. The author picks a destination (cancel does not move). Confirm posts public REST
POST /rest/folders/move/itemand the editor stays on the same content id. View and Promote do not show the action. HTTP 403, 404, and 409 are visible failures. Choosing the folder the item is already in does not post.Operator: Grok: night-issue-prs (model grok-4.7)
Test plan
npm run test:surface -- --path tests/editor-host-move.spec.js— 2 passed. Live move lists the item in the destination and not the source. Cancel and view mode covered. Missing folder shows the error and leaves the item in the source.Product documentation
product-docs/8.2/admin/content-explorer.mdPre-PR Maven
cd WebUI && rtk mvn clean install— BUILD SUCCESS. Vitest Test Files 528 passed, Tests 4875 passed. Java Tests run: 69, Failures: 0.cd modules/perc-qa-automation && rtk mvn clean install— BUILD SUCCESS (no Java tests).URL.createObjectURLFile stub invitest.setup.tsso the existing image-preview test does not throw under Vitest 5 / Node 22.22.0.UI proof (C5)
python3 docker/scripts/perc-devctl.py qa-up --skip-image-build— TEST_CMS_URL=http://127.0.0.1:9993, container perc-matrix-cms-h2qa-healthRESULT:OK HTTP:200 HEALTH:healthyqa-deploy-webuithenqa-healthagain RESULT:OKTEST_CMS_URL=http://127.0.0.1:9993 TEST_DB_TYPE=h2 TEST_PRODUCT=cms npm run test:surface -- --path tests/editor-host-move.spec.js— 2 passedPre-push local code review
Independent Erlang pass (mkd-code-review 0.1.18, pack percussion, gate advisory). Persona: erlang 0.1.1. Persona source: /home/nate/.local/share/mkd/agents/erlang. 0 blocking bugs. Intent: edit-mode folder move stays on the same content id; cancel, view/promote, same-folder, and 403/404/409 are not success. Vitest + Playwright companions and product-docs are in the diff. No rule-file changes.