Skip to content

feat(editor): move the open item to another folder (#4774) - #4781

Merged
natechadwick-intsof merged 2 commits into
mainfrom
fix/issue-4774-editor-move-folder
Sep 23, 2026
Merged

natechadwick-intsof merged 2 commits into
mainfrom
fix/issue-4774-editor-move-folder

Conversation

@natechadwick-intsof

@natechadwick-intsof natechadwick-intsof commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Parent: #4532. Slice #4774.

Edit mode on the React EditorHost can Move to folder. The author picks a destination (cancel does not move). Confirm posts public REST POST /rest/folders/move/item and the editor stays on the same content id. View and Promote do not show the action. HTTP 403, 404, and 409 are visible failures. Choosing the folder the item is already in does not post.

Operator: Grok: night-issue-prs (model grok-4.7)

Test plan

  • Vitest: parent-folder path helpers, 403/404/409 mapping, confirm move stays on the same id, cancel, same-folder, view mode hides the control
  • Playwright H2: npm run test:surface -- --path tests/editor-host-move.spec.js — 2 passed. Live move lists the item in the destination and not the source. Cancel and view mode covered. Missing folder shows the error and leaves the item in the source.
  • Human QA: open an item in Edit, move it to another folder, confirm Explorer lists it only in the destination and the editor content id is unchanged. Confirm View has no Move control.

Product documentation

  • Updated product-docs/8.2/admin/content-explorer.md

Pre-PR Maven

  • modules_built: WebUI, modules/perc-qa-automation
  • cd WebUI && rtk mvn clean install — BUILD SUCCESS. Vitest Test Files 528 passed, Tests 4875 passed. Java Tests run: 69, Failures: 0.
  • cd modules/perc-qa-automation && rtk mvn clean install — BUILD SUCCESS (no Java tests).
  • downstream_checked: none (no public Java type or signature change)
  • Vitest URL.createObjectURL File stub in vitest.setup.ts so the existing image-preview test does not throw under Vitest 5 / Node 22.22.0.

UI proof (C5)

  • python3 docker/scripts/perc-devctl.py qa-up --skip-image-build — TEST_CMS_URL=http://127.0.0.1:9993, container perc-matrix-cms-h2
  • qa-health RESULT:OK HTTP:200 HEALTH:healthy
  • qa-deploy-webui then qa-health again RESULT:OK
  • TEST_CMS_URL=http://127.0.0.1:9993 TEST_DB_TYPE=h2 TEST_PRODUCT=cms npm run test:surface -- --path tests/editor-host-move.spec.js — 2 passed
  • console-clean=yes (after stubbing unrelated related-content canvas 404 on this image)
  • server.log-clean=yes for the move itself. Seed helper check-in of a new asset logged pre-existing check-in conflict lines; not the move POST.

Pre-push local code review

Independent Erlang pass (mkd-code-review 0.1.18, pack percussion, gate advisory). Persona: erlang 0.1.1. Persona source: /home/nate/.local/share/mkd/agents/erlang. 0 blocking bugs. Intent: edit-mode folder move stays on the same content id; cancel, view/promote, same-folder, and 403/404/409 are not success. Vitest + Playwright companions and product-docs are in the diff. No rule-file changes.

## Summary

Machine analysis found **0** finding(s), **0** bug(s).

## Scope

- Base: origin/main
- Head: HEAD
- Files: 9 analyzed
- Persona: erlang 0.1.1
- Persona source: /home/nate/.local/share/mkd/agents/erlang

## Recommendation

approve

## Gate

- Blocking bugs: 0
- May commit/push: yes

## Issues

_No issues._

Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs.

@natechadwick-intsof

Copy link
Copy Markdown
Collaborator Author

LGTM. Independent Erlang pass (did not author): mkd-code-review 0.1.18, pack percussion, gate advisory, 0 bugs. Persona: erlang 0.1.1. Persona source: ~/.local/share/mkd/agents/erlang. Editor move posts /rest/folders/move/item and does not treat cancel, view/promote, same-folder, or HTTP 403/404/409 as success. Full CLI report is in the PR body and docs/ai-generated/code-reviews/pr-4781-erlang.md (2a19e5a). GitHub rejected same-login APPROVE.

Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs-erlang.

Edit mode can move the open item with POST /rest/folders/move/item and stay on the same content id. Cancel, view mode, and HTTP 403/404/409 do not count as a successful move.

> Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs-erlang.
@natechadwick-intsof
natechadwick-intsof force-pushed the fix/issue-4774-editor-move-folder branch from 2a19e5a to 7c74d56 Compare September 23, 2026 15:52
@natechadwick-intsof

Copy link
Copy Markdown
Collaborator Author

Rebased onto origin/main after #4780 landed. The only conflict was WebUI/src/main/frontend/vitest.setup.ts: kept main's URL.createObjectURL jsdom fallback and this branch's revokeObjectURL guard.

cd WebUI && rtk mvn clean install — BUILD SUCCESS. Surefire Tests run: 69, Failures: 0. Vitest Test Files 529 passed.

Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs.

@natechadwick-intsof
natechadwick-intsof merged commit 983115e into main Sep 23, 2026
8 checks passed
@natechadwick-intsof
natechadwick-intsof deleted the fix/issue-4774-editor-move-folder branch September 23, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model:grok-4.7 Session model grok-4.7 operator:grok Changes authored by Grok operator:night-issue-prs night-issue-prs workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant