Skip to content

feat(publish): open a log item in the content editor (#4766) - #4780

Merged
natechadwick-intsof merged 2 commits into
mainfrom
fix/issue-4766-publish-log-open-editor
Sep 23, 2026
Merged

natechadwick-intsof merged 2 commits into
mainfrom
fix/issue-4766-publish-log-open-editor

Conversation

@natechadwick-intsof

Copy link
Copy Markdown
Collaborator

Summary

PublishingShell log item details can open the published content id in the React content editor. The shell probes GET …/itemmanagement/item/fields/{id} first. HTTP 403 and 404 stay on the log item as an error and do not navigate the editor. A click reserves a popup so the open is not blocked after the probe; a failed probe closes that window.

Parent: #4531. Fixes #4766.

Operator: Grok: night-issue-prs (model grok-4.7)

Test plan

  1. Publish → Logs, open job details, view an item row, choose Open in editor. The editor host opens for that content id.
  2. When the fields probe returns 403 or 404, the log item shows the error and the editor URL is not opened.
  3. QA H2: python3 docker/scripts/perc-devctl.py qa-up then qa-health (TEST_CMS_URL=http://127.0.0.1:9993, HEALTH:healthy). Copied WebUI/target/generated-webui/cm/modern/assets into perc-matrix-cms-h2 /opt/Percussion/jetty/base/webapps/Rhythmyx/cm/modern/assets/. qa-health again HEALTH:healthy. npm run test:surface -- --path tests/publishing-log-open-editor.spec.js — 3 passed. console-clean=yes (intentional 403/404 resource lines filtered). server.log-clean=yes. qa-down removed the cell.

Checklist

  • Product documentation — updated product-docs/8.2/admin/publishing.md (Logs: Open in editor, 403/404).
  • Unit / module tests — openLogItemInEditor and LogDetailsPanel Vitest.
  • WebUI + Playwright — modules/perc-qa-automation/frontend/tests/publishing-log-open-editor.spec.js (3 passed on H2).
  • Build gates — see C3 evidence.
  • Cross-platform — N/A (no filesystem path I/O).

C3 evidence

  • modules_built: WebUI
  • downstream_checked: none (no Java type made final/sealed and no public/protected signature change)
  • cd WebUI && rtk mvn clean install — BUILD SUCCESS. Surefire Tests run: 69, Failures: 0. Vitest Test Files 528 passed, Tests 4870 passed. Pre-existing javadoc/dependency warnings only; no new compiler warnings from this change. npm EBADENGINE on Node 22.22.0 is the pinned frontend-maven Node (jsdom wants 22.22.2); Vitest stubs URL.createObjectURL when that runtime throws.

C5 UI proof

  • qa-up: python3 docker/scripts/perc-devctl.py qa-up — TEST_CMS_URL=http://127.0.0.1:9993 QA_CMS_HOST_PORT=9993
  • qa-health: RESULT:OK HTTP:200 HEALTH:healthy
  • deploy: docker cp modern assets into the Rhythmyx webapp (UI bundle, not a classpath jar). qa-health again HEALTH:healthy. No Jetty restart (static assets). No docker restart of the cell.
  • Playwright: cd modules/perc-qa-automation/frontend && npm run test:surface -- --path tests/publishing-log-open-editor.spec.js — 3 passed
  • console-clean=yes
  • server.log-clean=yes

Pre-push local code review

## Summary

Machine analysis found **0** finding(s), **0** bug(s).

## Scope

- Base: origin/main
- Head: HEAD
- Files: 8 analyzed
- Persona: erlang 0.1.1
- Persona source: /home/nate/.local/share/mkd/agents/erlang

## Recommendation

approve

## Gate

- Blocking bugs: 0
- May commit/push: yes

## Issues

_No issues._

Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs.

Publishing log item details probe item fields, then open the React
editor for that content id. HTTP 403 and 404 stay on the log row.

Fixes #4766

> Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs.
@natechadwick-intsof natechadwick-intsof added operator:grok Changes authored by Grok operator:night-issue-prs night-issue-prs workflow model:grok-4.7 Session model grok-4.7 labels Sep 23, 2026
> Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs.
@natechadwick-intsof

Copy link
Copy Markdown
Collaborator Author

LGTM. Independent Erlang pass (did not author): mkd-code-review 0.1.18, pack percussion, gate advisory, 0 bugs. Persona: erlang 0.1.1. Persona source: ~/.local/share/mkd/agents/erlang. Base origin/main, head 9c61335. Publish-log open probes item fields; 403/404 stay on the row and close the reserved popup. Vitest, Playwright, and product-docs are present. Required checks were green on this snapshot. GitHub rejected same-login APPROVE; squash-merging.

Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs-erlang.

@natechadwick-intsof
natechadwick-intsof merged commit e04e02f into main Sep 23, 2026
8 checks passed
@natechadwick-intsof
natechadwick-intsof deleted the fix/issue-4766-publish-log-open-editor branch September 23, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model:grok-4.7 Session model grok-4.7 operator:grok Changes authored by Grok operator:night-issue-prs night-issue-prs workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

issue 4531 slice 23: PublishingShell open log item in editor

1 participant