fix(perc-content-explorer): PSItemAssemblyManager rawtypes residual (#3057)

[natechadwick-intsof]

Summary

Parameterize residual raw Iterator / Map / HashMap on PSItemAssemblyManager in modules/DesktopContentExplorer (insert/delete/update/reorder node lists + active-assembly postData payload). Extract pure static helpers with behavioral unit tests. No product behavior change.

Parent residual tracker: #2326
Parent module tracker: #2045
Parent monorepo tracker: #2200
Prior slice: #3012 (PSOptionManager)

Changes

• Iterator → Iterator<PSNode> on public insert/delete/update/reorder APIs and private buildRequest
• Map/HashMap postData → Map<String, String> via buildActiveAssemblerParams
• Pure helpers: isSlotTarget, resolveDropIndex, resolveReorderDropIndex, buildActiveAssemblerParams
• PSItemAssemblyManagerTest (11 tests)

Test plan

• cd modules/DesktopContentExplorer && ../../mvnw.cmd clean install — BUILD SUCCESS
• PSItemAssemblyManagerTest: 11 tests, 0 failures
• Module suite: Tests run: 159, Failures: 0, Errors: 0
• Erlang pre-commit review: approve (docs/ai-generated/code-reviews/issue-3057-psitemassemblymanager-rawtypes-erlang.md)

Gates evidence

• modules_built: modules/DesktopContentExplorer
• build_evidence: ..\..\mvnw.cmd clean install from module dir → BUILD SUCCESS; Tests run: 159, Failures: 0, Errors: 0; PSItemAssemblyManagerTest: 11
• downstream_checked: monorepo grep for PSItemAssemblyManager — call sites only in same-module PSActionManager (already typed Iterator<PSNode>). No reverse-dep modules require reinstall (C2 public signature is erasure-compatible Iterator→Iterator<PSNode>).
• Product documentation: N/A — pure tech-debt/rawtypes; no operator- or user-visible behavior change.

Operator

Operator: Grok: night-issue-prs (model grok-4.5)

Fixes #3057

Co-Authored by Grok Build using grok-4.5 with agent main.

[kilo-code-bot]

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)

• docs/ai-generated/code-reviews/issue-3057-psitemassemblymanager-rawtypes-erlang.md
• modules/DesktopContentExplorer/src/main/java/com/percussion/cx/PSItemAssemblyManager.java
• modules/DesktopContentExplorer/src/test/java/com/percussion/cx/PSItemAssemblyManagerTest.java

---

_{Reviewed by step-3.7-flash · Input: 67K · Output: 20.3K · Cached: 345.9K}

_{Review guidance: REVIEW.md from base branch main}