Repository navigation
fix(deployer): Xlint ContentRelation handler generics (#3017) - #3046
Merged
Merged
Conversation
Clear ~68 main-source Xlint diagnostics on PSContentRelationDependencyHandler after batch 10 (#3016): real Iterator/List/Map generics, remove redundant casts, typed relationshipMap and processFieldSet maps, lock API shapes with PSContentRelationHandlerTypedTest. Residual remains (ContentType ~69, others). Fixes #3017 Partial #2028 #2200 > Co-Authored by Grok Build using grok-4.5 with agent main.
natechadwick-intsof
added
operator:grok
This was referenced Aug 11, 2026
Collaborator
Author
|
Residual after this PR: #3047 (PSContentTypeDependencyHandler ~69). No human QA — pure tech-debt generics; agent-proven via deployer clean install.
|
natechadwick
approved these changes
Aug 11, 2026
5 tasks done
natechadwick
pushed a commit
that referenced
this pull request
Aug 11, 2026
…3059) Clear ~69 main-source Xlint diagnostics on PSContentTypeDependencyHandler after ContentRelation (#3017/#3046): typed Iterator overrides, id-types List mappings, archive file iterators, PSPair diamond, local workflow List cast. Signature unit test PSContentTypeHandlerTypedTest. Fixes #3047 Partial #2028 #2200 > Co-Authored by Grok Build using grok-4.5 with agent main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continue perc-deployer Xlint cleanup after batch 10 (#3016). This slice clears PSContentRelationDependencyHandler (~68 main-source diagnostics) with real generics:
Iterator/List/Map/Setsurfaces for install, id-types, and inline-link processingMap<Integer, PSRelationship>relationship map; typed JDBC/table field maps inprocessFieldSetList<PSRelationship>formodifyField(no uncheckedPSRelationshipSetconversion)PSContentRelationHandlerTypedTest@SuppressWarningsFixes #3017
Partial #2028 (perc-deployer Xlint epic)
Partial #2200 (monorepo Xlint/javadoc tracker)
Prior: PR #3016 batch 10 ContentAssembler/Content/ContentListDef
Operator: Grok: night-issue-prs (model grok-4.5)
Test plan
cd deployer && ../mvnw.cmd clean install(JDK 21) — expect BUILD SUCCESSPSContentRelationHandlerTypedTestruns (2 tests)PSContentRelationDependencyHandler.javaPSContentTypeDependencyHandleras top main-source residual (~69)Checklist
PSContentRelationHandlerTypedTest; deployer standalone clean install greencd deployer && ../mvnw.cmd clean install→ BUILD SUCCESS; Tests run: 237, Failures: 0, Errors: 0, Skipped: 19C3 evidence
deployercd deployer; ../mvnw.cmd clean install→ BUILD SUCCESS; Tests run: 237, Failures: 0;PSContentRelationHandlerTypedTestTests run: 2, Failures: 0; zero Xlint onPSContentRelationDependencyHandler