Repository navigation
fix(perc-system): cms.objectstore serialVersionUID inventory + test companion (#2403) - #2433
Merged
Merged
Conversation
…ompanion (#2403) Inventory after #2297 foundation batch: all 20 true Serializable types under com.percussion.cms.objectstore (incl. client/server exceptions) already declare serialVersionUID; zero remaining -Xlint:serial missing-UID diagnostics in the package. Non-Serializable PSDbComponent collection subclasses correctly have no UID (same policy as design.objectstore dead-UID cleanup). Add PSCmsObjectStoreSerialVersionUidTest: field presence for all 20 types plus Java serialization round-trips for keys, permissions, cloning request/options, and exceptions constructible without a live server. Parent: #2022 / #2200. Sibling residuals #2404 (this-escape), #2405 (serial-field). Fixes #2403 Refs #2022 #2200 #2297 > Co-Authored by Grok Build using grok-4.5 with agent main.
This was referenced Aug 8, 2026
Collaborator
Author
|
Residuals filed with this PR:
Sibling objectstore work remains open: #2404 this-escape, #2405 serial-field.
|
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Reviewed by step-3.7-flash · Input: 46.8K · Output: 3.9K · Cached: 188.5K Review guidance: REVIEW.md from base branch |
natechadwick
approved these changes
Aug 8, 2026
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#2403 (parent #2022 / grandparent #2200, slice 3e after #2366): clear
-Xlint:serialmissing-serialVersionUIDfor remaining cms.objectstore types.Inventory result (this PR)
Reflection +
-Xlint:serialcompile ofcom.percussion.cms.objectstoreshows 0 missing serialVersionUID diagnostics. All 20 trueSerializabletypes already declare UIDs from the #2297 foundation batch:PSComponent/PSKeyPSKey,PSSimpleKey,PSItemChildLocator,PSFolder,PSComponentSummary,PSSite, cloning request/options,PSAaRelationshipIPSCatalogSummary→IPSCatalogIdentifier→SerializablePSAction,PSSearch,PSDisplayFormat,PSItemDefSummary,PSItemDefinitionPSInvalid*,PSRemoteException,PSCorruptDatabaseExceptionPSObjectPermissionsPSFolderPermissionsNon-
SerializablePSDbComponentcollection subclasses correctly have no UID (same policy as design.objectstore dead-UID cleanup #994baa0).Companion test
New
PSCmsObjectStoreSerialVersionUidTest:Serializableand declares a non-zero static finalserialVersionUIDOut of scope (already filed or residual)
PSItemDefinitionfields → issue 2022 slice 3g: serial-field hottest design.objectstore editors after #2366 #2405com.percussion.cms.PSCmsExceptionmissing UID (parent package, not objectstore) → residual belowTest plan
cd system && ../mvnw.cmd clean install— BUILD SUCCESSPSCmsObjectStoreSerialVersionUidTest— 4 tests, 0 failuresGates evidence
cd system)Residuals (filed with this PR)
PSCmsExceptionmissingserialVersionUIDundercom.percussion.cms(adjacent package)Operator
Operator: Grok: night-issue-prs (model grok-4.5)
Fixes #2403
Refs #2022 #2200 #2297 #2366