Skip to content

fix(perc-content-explorer): PSActionManager rawtypes residual batch (#2326) - #2371

Merged
natechadwick merged 1 commit into
mainfrom
fix/issue-2326-psactionmanager-rawtypes
Aug 8, 2026
Merged

natechadwick merged 1 commit into
mainfrom
fix/issue-2326-psactionmanager-rawtypes

Conversation

@natechadwick-intsof

Copy link
Copy Markdown
Collaborator

Summary

Residual javac -Xlint batch for perc-content-explorer after batch 1 (#2045 / #2327): clear the PSActionManager rawtypes/unchecked cluster (~114 → 0 on that file under full inventory).

  • Typed PSSelection / PSClipBoard (Iterator<PSNode>, List<String> types, clipboard map)
  • Generics sweep in PSActionManager (selection nodes, action children adapters, maps, listeners, loadChildren, paste/search helpers)
  • PSIteratorUtils.iterator(T) / emptyIterator() genericized (utils)
  • splitUrl map typing
  • Fixed empty-statement bug in isRender (always returned false before)
  • Behavioral tests: PSSelectionTest, PSClipBoardTest
  • Erlang pre-commit review: docs/ai-generated/code-reviews/issue-2326-psactionmanager-rawtypes-erlang.md

Partial for #2326. Parent trackers: #2045, #2200.

Residuals filed

Inventory (-Xmaxwarns 5000)

Metric Before After
Module total ~1164 ~1060
PSActionManager ~114 0

Test plan

  • modules/utils: mvnw clean install green
  • modules/DesktopContentExplorer: mvnw clean install green (16 tests, 0 failures)
  • Full javac inventory: PSActionManager clean

Gates

  • Erlang self-review: pass (no bugs; portable paths N/A; tests present)
  • Per-module clean install: utils + perc-content-explorer
  • No product behavior change intended (except isRender empty-if fix which previously always returned false)

Operator: Grok: night-issue-prs (model grok-4.5)

Co-Authored by Grok Build using grok-4.5 with agent main.

…2326)

Type PSSelection/PSClipBoard node iterators, generics sweep in PSActionManager
(action children, selection nodes, maps, listeners), generic PSIteratorUtils
singleton/empty iterators, and splitUrl Map typing. Clear ~114 PSActionManager
Xlint diagnostics (file now clean). Behavioral tests for selection/clipboard.

Partial for #2326 / #2045. Refs #2200.

> Co-Authored by Grok Build using grok-4.5 with agent main.
@kilo-code-bot

kilo-code-bot Bot commented Aug 8, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (8 files)
  • docs/ai-generated/code-reviews/issue-2326-psactionmanager-rawtypes-erlang.md
  • modules/DesktopContentExplorer/src/main/java/com/percussion/cx/PSActionManager.java
  • modules/DesktopContentExplorer/src/main/java/com/percussion/cx/PSClipBoard.java
  • modules/DesktopContentExplorer/src/main/java/com/percussion/cx/PSContentExplorerUtils.java
  • modules/DesktopContentExplorer/src/main/java/com/percussion/cx/PSSelection.java
  • modules/DesktopContentExplorer/src/test/java/com/percussion/cx/PSClipBoardTest.java
  • modules/DesktopContentExplorer/src/test/java/com/percussion/cx/PSSelectionTest.java
  • modules/utils/src/main/java/com/percussion/utils/collections/PSIteratorUtils.java

Reviewed by step-3.7-flash · Input: 163.2K · Output: 20.2K · Cached: 2.1M

Review guidance: REVIEW.md from base branch main

@natechadwick
natechadwick merged commit e8f2484 into main Aug 8, 2026
6 checks passed
@natechadwick
natechadwick deleted the fix/issue-2326-psactionmanager-rawtypes branch August 8, 2026 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model:grok-4.5 Grok 4.5 model operator:grok Changes authored by Grok operator:night-issue-prs night-issue-prs workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants