Repository navigation
fix(perc-content-explorer): PSActionManager rawtypes residual batch (#2326) - #2371
Merged
Merged
Conversation
…2326) Type PSSelection/PSClipBoard node iterators, generics sweep in PSActionManager (action children, selection nodes, maps, listeners), generic PSIteratorUtils singleton/empty iterators, and splitUrl Map typing. Clear ~114 PSActionManager Xlint diagnostics (file now clean). Behavioral tests for selection/clipboard. Partial for #2326 / #2045. Refs #2200. > Co-Authored by Grok Build using grok-4.5 with agent main.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (8 files)
Reviewed by step-3.7-flash · Input: 163.2K · Output: 20.2K · Cached: 2.1M Review guidance: REVIEW.md from base branch |
natechadwick
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Residual javac
-Xlintbatch forperc-content-explorerafter batch 1 (#2045 / #2327): clear the PSActionManager rawtypes/unchecked cluster (~114 → 0 on that file under full inventory).PSSelection/PSClipBoard(Iterator<PSNode>,List<String>types, clipboard map)PSActionManager(selection nodes, action children adapters, maps, listeners,loadChildren, paste/search helpers)PSIteratorUtils.iterator(T)/emptyIterator()genericized (utils)splitUrlmap typingisRender(always returned false before)PSSelectionTest,PSClipBoardTestdocs/ai-generated/code-reviews/issue-2326-psactionmanager-rawtypes-erlang.mdPartial for #2326. Parent trackers: #2045, #2200.
Residuals filed
Inventory (
-Xmaxwarns 5000)Test plan
modules/utils:mvnw clean installgreenmodules/DesktopContentExplorer:mvnw clean installgreen (16 tests, 0 failures)Gates
isRenderempty-if fix which previously always returned false)Operator: Grok: night-issue-prs (model grok-4.5)