Repository navigation
fix(perc-content-explorer): PSNode generics javac warnings batch 1 (#2045) - #2327
Merged
Merged
Conversation
#2045) Type children, row data, table meta, type collections, and related APIs on PSNode to clear the objectstore rawtypes/unchecked cluster. Call-site fix for empty children iterators; expand PSNodeTest behavioral coverage. Partial for #2045. Refs #2200. > Co-Authored by Grok Build using grok-4.5 with agent main.
natechadwick-intsof
added
operator:grok
This was referenced Aug 7, 2026
natechadwick
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR-sized batch 1 real-fix of javac diagnostics in
modules/DesktopContentExplorer(perc-content-explorer, issue #2045): typePSNode(children, row data, table meta, type collections, dirty-children helpers) and a minimal call-site fix for empty children iterators.Fixed in this PR
List<PSNode>,Map<String,Object>row data,Map.Entry<String,String>column defs,Collection<String>folder/search types, typed iterators for children / dirty children / display format; nestedTableMeta/RowDatagenericsCollections.emptyIterator()for empty search children (PSIteratorUtils.emptyIterator()returnedIterator<Object>)PSNodeTest(9 green)Residual
True module residual under
-Xmaxwarns 5000is still large (~1121; issue “100” figure matches javac default cap). Follow-on residual issue:#2326
Parent module tracker: #2045
Monorepo tracker: #2200
Test plan
cd modules/DesktopContentExplorer→../../mvnw.cmd clean install→ BUILD SUCCESSPSNode.java: 0 javac diagnostics under project-Xlintdocs/ai-generated/code-reviews/issue-2045-content-explorer-javac-batch1-erlang.md)Gates evidence
Partial for #2045 (residual filed). Refs #2200
Operator: Grok: night-issue-prs (model grok-4.5)