[SYCL] Enable aspect usage propagation pass and add diagnostics #6982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a warning diagnostic for when there is a mismatch between aspect usage propagated to a function and the function's `device_has` attribute. Additionally, notes accompany the warning to give the user a trace through to where the aspects originate. Since the aspects are propagated in an LLVM pass, the warning is issued from there, which means no source information is available by default. To alleviate this, Clang CodeGen will now add srcloc metadata with an encoded version of the source location to allow the backend to correctly report the location for the various new diagnostics. Additionally, this commit also adds the SYCLPropagateAspectsUsage pass to the passes run for SYCL device code. Co-authored-by: Sabianin, Maksim <maksim.sabianin@intel.com> Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Fznamznon
reviewed
Oct 10, 2022
| @@ -1086,6 +1086,14 @@ void CodeGenFunction::StartFunction(GlobalDecl GD, QualType RetTy, | |||
| Fn->setMetadata("sycl_used_aspects", | |||
| llvm::MDNode::get(getLLVMContext(), AspectsMD)); | |||
| } | |||
|
|
|||
| // SYCL needs to know the source location of functions for diagnostics in | |||
| // the aspect propagation pass. Save the token in a srcloc metadata node. | |||
There was a problem hiding this comment.
I heard that not all optimizations care about metadata. Will it work when early optimizations enabled?
There was a problem hiding this comment.
The pass that uses srcloc relies on other metadata too, so we need it to run as early as possible. As such, srcloc should also be preserved with early opts too. As you suggest in the other comment, it may make sense to add it to the tests.
There was a problem hiding this comment.
I have added a test checking that it works with early optimizations: sycl/test/warnings/aspect_perserve_srcloc.cpp
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
|
/verify with intel/llvm-test-suite#1353 |
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
|
/verify with intel/llvm-test-suite#1353 |
1 similar comment
|
/verify with intel/llvm-test-suite#1353 |
asudarsa
approved these changes
Nov 2, 2022
steffenlarsen
changed the title
elizabethandrews
approved these changes
Nov 2, 2022
|
/verify with intel/llvm-test-suite#1353 |
smanna12
approved these changes
Nov 3, 2022
Fznamznon
approved these changes
Nov 3, 2022
premanandrao
approved these changes
Nov 3, 2022
dm-vodopyanov
approved these changes
Nov 3, 2022
|
Remaining verification failure in OpenCL on Windows for KernelAndProgram/kernel-bundle-merge-options-env.cpp is a known issue. |
0x12CC
pushed a commit
to oneapi-src/SYCLomatic-test
that referenced
this pull request
Dec 6, 2022
…anged compiler behavior (#146) * fix CI failed, due to compiler change after 20221202 Signed-off-by: Ni, Wenhui <wenhui.ni@intel.com> * disable math_exec math_habs on gen12 Signed-off-by: Ni, Wenhui <wenhui.ni@intel.com>
This was referenced Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a warning diagnostic for when there is a mismatch between aspect usage propagated to a function and the function's
device_hasattribute. Additionally, notes accompany the warning to give the user a trace through to where the aspects originate. Since the aspects are propagated in an LLVM pass, the warning is issued from there, which means no source information is available by default. To alleviate this, Clang CodeGen will now add srcloc metadata with an encoded version of the source location to allow the backend to correctly report the location for the various new diagnostics.Additionally, this commit also adds the SYCLPropagateAspectsUsage pass to the passes run for SYCL device code.