Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Test exception throwing for unsupported kernel feature #1314

Merged
merged 5 commits into from
Nov 21, 2022

Conversation

KornevNikita
Copy link

sycl patch: intel/llvm#6989

@KornevNikita KornevNikita marked this pull request as ready for review October 7, 2022 15:07
@KornevNikita KornevNikita requested a review from a team as a code owner October 7, 2022 15:07
Copy link

@dm-vodopyanov dm-vodopyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Maybe use exception handler?

@KornevNikita
Copy link
Author

KornevNikita commented Oct 27, 2022

Waiting for intel/llvm#6982 to test

@KornevNikita
Copy link
Author

Re-run tests

@KornevNikita KornevNikita reopened this Nov 8, 2022
@KornevNikita
Copy link
Author

Failure is unrelated

@KornevNikita KornevNikita requested a review from a team November 8, 2022 15:35
@KornevNikita
Copy link
Author

@intel/llvm-gatekeepers

Copy link

@AlexeySachkov AlexeySachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[2022-11-08T14:12:02.560Z] ********************

[2022-11-08T14:12:02.560Z] Failed Tests (1):

[2022-11-08T14:12:02.560Z]   SYCL :: OptionalKernelFeatures/throw-exception-for-unsupported-aspect.cpp

[2022-11-08T14:12:02.560Z] 

This can't be an unrelated failure. Linux, OpenCL

@KornevNikita
Copy link
Author

@AlexeySachkov oh, I believe it's enough to re-run tests, it was fixed in de9a209

@KornevNikita
Copy link
Author

I found out that there is no support for device_has yet, so we see this failure. Moving to draft until device_has support is ready.

@KornevNikita KornevNikita marked this pull request as draft November 10, 2022 15:36
@KornevNikita
Copy link
Author

Support for device_has: intel/llvm#7419

@KornevNikita KornevNikita marked this pull request as ready for review November 21, 2022 10:33
@KornevNikita
Copy link
Author

Re-run CI

@KornevNikita KornevNikita reopened this Nov 21, 2022
@KornevNikita
Copy link
Author

@AlexeySachkov I believe this time failures are really unrelated.

@AlexeySachkov AlexeySachkov merged commit bde7457 into intel:intel Nov 21, 2022
@KornevNikita KornevNikita deleted the aspect-exception branch December 9, 2022 14:46
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants