This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Prevent use of fp64 and fp16 when unsupported in more tests #1353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of tests currently use double and sycl::half despite them not being supported by the used device. Although it does not necessarily fail to run on those devices, they are not considered supported by the SYCL specification and should not be used in testing on those devices. This commit prevent parts of a selection of tests from running on devices that do not support the types used. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Pennycook
reviewed
Oct 27, 2022
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Pennycook
approved these changes
Oct 27, 2022
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
v-klochkov
approved these changes
Nov 3, 2022
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
AlexeySachkov
approved these changes
Nov 3, 2022
SYCL/Basic/stream/stream.cpp
Outdated
Comment on lines
101
to
102
| // NOTE: Double-precision floating point tests cannot be done here as | ||
| // they may not be supported by the device. |
There was a problem hiding this comment.
Did we move them into a separate test? Or do we rely on SYCL-CTS for double?
There was a problem hiding this comment.
You're right, we should keep the coverage. I've given it the same treatment as printf tests.
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
|
@v-klochkov - I have added a handful more cases, most of which are for ESIMD with fp16. Could you please have another pass over it? |
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
v-klochkov
approved these changes
Nov 4, 2022
|
Failure in SYCL :: KernelAndProgram/kernel-bundle-merge-options-env.cpp for OpenCL is seen in other PRs. |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…-topic [SYCL] Update inlineASM tests to use subgroup size 16 instead of 8.
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…ntel#1353) A number of tests currently use double and sycl::half despite them not being supported by the used device. Although it does not necessarily fail to run on those devices, they are not considered supported by the SYCL specification and should not be used in testing on those devices. This commit prevent parts of a selection of tests from running on devices that do not support the types used. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…ntel#1353) (intel#1396) A number of tests currently use double and sycl::half despite them not being supported by the used device. Although it does not necessarily fail to run on those devices, they are not considered supported by the SYCL specification and should not be used in testing on those devices. This commit prevent parts of a selection of tests from running on devices that do not support the types used. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com> Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com> Co-authored-by: Steffen Larsen <steffen.larsen@intel.com>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…ntel/llvm-test-suite#1353) A number of tests currently use double and sycl::half despite them not being supported by the used device. Although it does not necessarily fail to run on those devices, they are not considered supported by the SYCL specification and should not be used in testing on those devices. This commit prevent parts of a selection of tests from running on devices that do not support the types used. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of tests currently use double and sycl::half despite them not being supported by the used device. Although it does not necessarily fail to run on those devices, they are not considered supported by the SYCL specification and should not be used in testing on those devices. This commit prevent parts of a selection of tests from running on devices that do not support the types used.