[SYCL][FPGA] Prepare future implementation of experimental pipe properties #5886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcolberg
force-pushed
the
sycl-ext-intel-experimental-pipes-properties
branch
2 times, most recently
from
eb65fa6 to
b640130
Compare
…rties Add a template parameter to pass compile-time constant properties to sycl::ext::intel::experimental::pipe, and redeclare pipe implementation as a specialization when the properties list is empty; otherwise, when the properties list is non-empty, throw a descriptive compiler error. The unnamed template parameter allows implementation of the case where the properties list is non-empty in a downstream, FPGA-specific header, before finalizing pipe properties for inclusion into this header. See draft specification in #5838
pcolberg
force-pushed
the
sycl-ext-intel-experimental-pipes-properties
branch
from
b640130 to
c521a84
Compare
|
Same unrelated test failures as outlined in #5766 (comment). |
|
Hi @intel/llvm-reviewers-runtime, since @cperkinsintel is unavailable for review, it would be great if you could take over the review in time for the next release. |
sherry-yuan
reviewed
Mar 25, 2022
|
@intel/llvm-reviewers-runtime could you take a quick look to ensure this gets in before code complete? |
|
Thanks @s-kanaev and @steffenlarsen for the quick review 🙂 @intel/llvm-gatekeepers could you merge in time for code complete? |
bader
changed the title
|
@intel/dpcpp-esimd-reviewers, FYI. 4 failing tests are failing on ESIMD emulator - https://github.com/intel/llvm/runs/5685843530?check_suite_focus=true. I don't think these failures are related to this PR, so I'm going to merge it. |
alexbatashev
added a commit
to alexbatashev/llvm
that referenced
this pull request
Apr 2, 2022
* sycl: (3343 commits) [SYCL][L0] Disable round-robin submissions to multiple CCSs (intel#5945) [SYCL][CUDA] Don't link pi_cuda against libsycl (intel#5908) [CI] Disable -Werror by default (intel#5889) [BuildBot] Uplift CPU/FPGAEMU RT version to 2022.13.3.0.16 (intel#5883) [SYCL][CUDA][libclc] Add support for atomic fp exchange and compare exchange (intel#5937) [SYCL] Fix device code outlining for static local variables (intel#5915) [SYCL][NFC] Refactor plugin CMakeLists.txt (intel#5799) [SPIR-V][Doc] Add JointMatrixWorkItemLengthINTEL instruction to joint matrix extension (intel#5781) [SYCL] Expand device_global map and make initialization order agnostic (intel#5902) [SYCL][CUDA] Add IPSCCP pass to O0 by default (intel#5900) [ESIMD] Disable ABI changes warnings in host compiler. (intel#5931) [SYCL] Make properties constructor constexpr (intel#5928) [NFC][SYCL] Fix static analysis warning (intel#5933) [CODEOWNERS][NFC] Assign code owners for CI scripts (intel#5873) [SYCL] Store the kernel object size in the integration header (intel#5862) [SYCL][ESIMD] Change esimd-verifier logic for detecting valid SYCL calls (intel#5914) [SYCL][CUDA][DOC] GettingStartedGuide.md to recommend cuda 11.6 (intel#5917) [SYCL][L0] Move command list cache usage under mutex (intel#5874) [SYCL][FPGA] Prepare future implementation of experimental pipe properties (intel#5886) [CI] Roll back intel driver to the latest version (intel#5925) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a template parameter to pass compile-time constant properties to
sycl::ext::intel::experimental::pipe, and redeclare pipe implementation
as a specialization when the properties list is empty; otherwise, when
the properties list is non-empty, throw a descriptive compiler error.
The unnamed template parameter allows implementation of the case where
the properties list is non-empty in a downstream, FPGA-specific header,
before finalizing pipe properties for inclusion into this header.
See draft specification in #5839
@GarveyJoe @rho180 @sherry-yuan @bsyrowik @tiwaria1 @ajaykumarkannan