[NFC][SYCL] Break include's cycle #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 28, 2020 11:08
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
alexbatashev
suggested changes
May 28, 2020
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
v-klochkov
reviewed
May 28, 2020
|
Overall Looks Good To Me. I'll mark approved (as reduction.hpp owner) after additional fixes for Alexander's comments. |
added 3 commits
May 28, 2020 21:12
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
s-kanaev
requested review from
v-klochkov,
alexbatashev,
turinevgeny and
romanovvlad
v-klochkov
approved these changes
May 28, 2020
alexbatashev
approved these changes
May 29, 2020
|
@turinevgeny @romanovvlad any comments from you? |
turinevgeny
approved these changes
Jun 1, 2020
No, the patch is OK to me. |
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jul 15, 2022
After intel#1770 some uses of associateWithHandler have to be guarded by "#ifndef __SYCL_DEVICE_ONLY__" as the accessor's inheritance chain differs between host/device compilation. Put the burden of that into the handler's implementation instead of paying the price at uses.
againull
pushed a commit
that referenced
this pull request
Jul 18, 2022
After #1770 some uses of associateWithHandler have to be guarded by "#ifndef __SYCL_DEVICE_ONLY__" as the accessor's inheritance chain differs between host/device compilation. Put the burden of that into the handler's implementation instead of paying the price at uses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes is required for #1747.
Suppose we add
#include <CL/sycl/accessor.hpp>ininterop_handle.hpp. Furthermore we will add#include <CL/sycl/interop_handle.hpp>toinclude/CL/sycl/handler.hpp. Then, we will have the following cycle (here->sayswhich includes):Also, this patch eliminates use of
reinterpret_cast(either as it is or C-style) when convertingaccessortoAccessorBaseHostat host.