[NFC][SYCL] Simplify usage of associateWithHandler #6450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After intel#1770 some uses of associateWithHandler have to be guarded by "#ifndef __SYCL_DEVICE_ONLY__" as the accessor's inheritance chain differs between host/device compilation. Put the burden of that into the handler's implementation instead of paying the price at uses.
againull
previously approved these changes
Jul 15, 2022
bader
reviewed
Jul 18, 2022
| @@ -20,8 +20,15 @@ namespace detail { | |||
|
|
|||
| class AccessorBaseHost; | |||
|
|
|||
| #ifndef __SYCL_DEVICE_ONLY__ | |||
There was a problem hiding this comment.
Minor readability improvement: when there is an else branch, it's better to avoid negation. I.e. prefer
#ifdef
X
#else
Y
#endifto
#ifndef
Y
#else
X
#endifThere was a problem hiding this comment.
Usually, I would have done that already. However, in cases when one branch is much more important/interesting than the other, the decision isn't so clear. Also, pre-existing usage of this in the file (beyond the affected lines) is such that the order is determined by what code it is (host - host is the first condition, device, inside parallel_for - device is the first condition), so I'm not sure if that's a positive change.
Anyway, I'm committed the suggested change. CodeOwners are free to either merge it or revert and merge the previous version.
bader
approved these changes
Jul 18, 2022
againull
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1770 some uses of associateWithHandler
have to be guarded by "#ifndef SYCL_DEVICE_ONLY" as the accessor's
inheritance chain differs between host/device compilation.
Put the burden of that into the handler's implementation instead of paying the
price at uses.