[SYCL] Introduce interop handle for host task #1747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
3 tasks
nyalloc
reviewed
May 26, 2020
added 3 commits
May 27, 2020 11:51
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
|
@steffenlarsen, @StuartDAdams Sorry, somehow I can't re-request review from you. @sergey-semenov ping |
added 5 commits
May 29, 2020 18:30
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
|
LGTM aside from the reinterpret_cast/include cycle issue. |
bader
pushed a commit
that referenced
this pull request
Jun 2, 2020
This changes is required for #1747. Suppose we add `#include <CL/sycl/accessor.hpp>` in `interop_handle.hpp` . Furthermore we will add `#include <CL/sycl/interop_handle.hpp>` to `include/CL/sycl/handler.hpp`. Then, we will have the following cycle (here `->` says `which includes`): ``` handler.hpp -> interop_handle.hpp -> accessor.hpp -> handler.hpp (cycle here) ``` Also, this patch eliminates use of `reinterpret_cast` (either as it is or C-style) when converting `accessor` to `AccessorBaseHost` at host.
added 3 commits
June 2, 2020 13:06
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
sergey-semenov
approved these changes
Jun 2, 2020
|
@s-kanaev, please, fix CI failures. |
Ping. |
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Jun 10, 2020
* upstream/sycl: [SYCL] Fix broken build after introduction USM to ocl headers (intel#1852) [SYCL][ESIMD] Implement "private globals" (file scope private vars) in FE (intel#1756) [SYCL] Introduce interop handle for host task (intel#1747)
Fznamznon
pushed a commit
to Fznamznon/llvm
that referenced
this pull request
Dec 5, 2022
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com> Original commit: KhronosGroup/SPIRV-LLVM-Translator@a3fc26f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is number one in series of patches for interop part of host task.
This patch introduces
interop_handleas described by proposal [1].[1] https://github.com/codeplaysoftware/standards-proposals/blob/master/host_task/host_task.md