-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][Doc][RTC] Document [un]supported features and build_options
#17459
base: sycl
Are you sure you want to change the base?
Conversation
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
sycl/doc/extensions/experimental/sycl_ext_oneapi_kernel_compiler.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_kernel_compiler.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_kernel_compiler.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_kernel_compiler.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_kernel_compiler.asciidoc
Outdated
Show resolved
Hide resolved
With the exception of the `-Xs` option, all other options to control | ||
ahead-of-time (AOT) compilation, such as `-fsycl-targets`, are unsupported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does "unsupported" mean? Is this undefined behavior, or can this be diagnosed via a errc::build
exception?
This question also applies to all instances of "unsupported" appearing below.
sycl/doc/extensions/experimental/sycl_ext_oneapi_kernel_compiler.asciidoc
Outdated
Show resolved
Hide resolved
The `kernel_compiler` implementation in {dpcpp} supports persistent caching. To | ||
enable it, set the the environment variable `SYCL_CACHE_PERSISTENT=1`. The | ||
location of the cache can be changed by setting `SYCL_CACHE_DIR`. Refer to | ||
https://intel.github.io/llvm/design/KernelProgramCache.html#persistent-cache for | ||
more details on how to control the cache. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this been reviewed somewhere else, perhaps as part of the design of the run-time compiler?
I'm a little surprised that JIT compilation of kernels embedded in the binary would use the same cache as explicit run-time compilation of kernels. I would have expected separate controls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation PR is #16823 and has been approved by @cperkinsintel.
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
Update the non-normative section in the
kernel_compiler
extension to reflect what's currently supported in DPCPP.