[SYCL][RTC] Rework handling of build_options
#17405
Merged
+68
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
|
I'll document the unsupported options we settle on here in the extension's implementation notes section in a separate PR. |
sommerlukas
approved these changes
Mar 12, 2025
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
|
Companion spec PR: #17459 |
jopperm
commented
Mar 14, 2025
| std::vector<std::string> flags{"-Xs '-doubleGRF'", | ||
| "-Xs'-Xfinalizer \"-printregusage\"'"}; | ||
| std::vector<std::string> flags{"-Xs", "-doubleGRF", | ||
| "-XsXfinalizer \"-printregusage\""}; |
There was a problem hiding this comment.
@cperkinsintel This occurred to me while working on the documentation:
- Do we still need to support the implicit unquoting, given
build_optionsare always a vector? I didn't find that in the "normal" option handling (but might have overlooked it). - The
-Xsoption says that for the joined form, a dash is inserted automatically, so-XsDfoobecomes-Dfoowhen passed to the target compiler.
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
|
I realised that invalid options shall trigger an exception with |
… detected Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
Done. @sommerlukas you may want to review b8b5d86. |
sommerlukas
approved these changes
Mar 18, 2025
KseniyaTikhomirova
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reject user-supplied arguments a bit more coarsely based on their kind or relation to an unsupported feature.