Skip to content

[CI] Drop support ext_oneapi_[level_zero|cuda|hip] in sycl_devices LIT parameter #16508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2025
Merged

[CI] Drop support ext_oneapi_[level_zero|cuda|hip] in sycl_devices LIT parameter #16508

merged 1 commit into from
Jan 3, 2025

Conversation

uditagarwal97
Copy link
Contributor

Instead of ext_oneapi_[level_zero|cuda|hip], we should use level_zero/cuda/hip backend name in LIT, which is in alignment with ONEAPI_DEVICE_SELECTOR terminology and sycl-ls output.

@uditagarwal97 uditagarwal97 self-assigned this Jan 3, 2025
@uditagarwal97 uditagarwal97 mentioned this pull request Jan 3, 2025
Merged
@uditagarwal97 uditagarwal97 marked this pull request as ready for review January 3, 2025 00:57
@uditagarwal97 uditagarwal97 requested review from a team as code owners January 3, 2025 00:57
sarnex
sarnex approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@uditagarwal97
Copy link
Contributor Author

@intel/llvm-gatekeepers I think we are good to merge this PR. The following failure in SYCL unit test is unrelated and reported in #16515.

PersistentDeviceCodeCacheImpl/PersistentDeviceCodeCache.ConcurentReadWriteCacheFileSize

The E2E failure on Gen12 is also flaky and reported in #8803.

@sarnex sarnex merged commit 075fe28 into sycl Jan 3, 2025
36 of 38 checks passed
@uditagarwal97 uditagarwal97 deleted the sycl-devops-pr/udit/remove_ext_oneapi branch January 3, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarnex sarnex sarnex approved these changes

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

@steffenlarsen steffenlarsen Awaiting requested review from steffenlarsen steffenlarsen is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees

@uditagarwal97 uditagarwal97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uditagarwal97 @sarnex @aelovikov-intel