[CI] Run E2E tests on PVC in precommit #16506
Conversation
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
changed the title
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| @@ -60,21 +60,6 @@ jobs: | |||
| image_options: -u 1001 --device=/dev/dri --device=/dev/kfd | |||
| target_devices: ext_oneapi_hip:gpu | |||
| reset_intel_gpu: false | |||
| - name: E2E tests on Intel Ponte Vecchio GPU | |||
| runner: '["Linux", "pvc"]' | |||
| env: '{"LIT_FILTER_OUT":"ESIMD/unified_memory_api/"}' | |||
There was a problem hiding this comment.
should we have it precommit only and not in both? is the limiting factor the number of machines?
There was a problem hiding this comment.
I think that should be a broader question and not specific to PVC.
There was a problem hiding this comment.
I don't think the number of PVC machine is the limiting factor here. I recall some work being done to move all post-commit testing to pre-commit. If that's still our long-term plan, I think we should enable PVC on pre-commit only (and perhaps Nightly). Otherwise, I don't see any technical limitation towards enabling PVC on both pre and post commit.
There was a problem hiding this comment.
yeah i guess this kind of falls back to what should we test in precommit vs postcommit vs nightly, my initial reaction is precommit should test things/build configurations most important and most likely for users to break/care about, postcommit should be one level down, and nightly one level below that, but im fine with precommit only
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers PR is ready to be merged. |
#15308 added PVC to post-commit. Since then, we have not seen any spurious E2E test timeouts on PVC, so testing on PVC seems stable enough to be moved to pre-commit.
Running E2E tests on PVC takes only about 5 minutes so moving PVC testing to pre-commit shouldn't cause any noticeable slowdown in pre commit testing.