-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL] List unsupported platforms in sycl-ls verbose mode #15166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This was suggested a while back, here: #6878 (comment) |
@dm-vodopyanov @al42and would you like me to do anything else for this patch? |
Thanks, nothing from my side. |
@intel/llvm-gatekeepers this should be ready to go. Thank you! |
@jchlanda, we need a review from @intel/unified-runtime-reviewers: |
My bad sorry, was a bit too hasty with this one. @intel/unified-runtime-reviewers would you be so kind and take a look at this, thank you. |
@intel/llvm-gatekeepers we've got all the approvals now, should be ready to go. Thank you! |
@jchlanda - It looks like this made Plugin/sycl-ls.cpp fail on the HIP machine in post-commit. Could you please have a look? |
Yeap, on it. |
/// Returns all unsupported (non-SYCL) platforms in the system. | ||
/// | ||
/// \return a vector of all unsupported non-SYCL platforms. | ||
static std::vector<platform> get_unsupported_platforms(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jchlanda - Sorry for the post-commit review, but I think we need to reconsider the design of this. This function is now a public interface of a SYCL class, but is not part of neither the standard nor an extension. We either need an extension written for this, or we need it hidden, either in the detail
namespace, by making it private
or both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the feedback, on it.
The runtime is able to recognised banned platforms, this patch provides a way to list them using
sycl-ls
'verbose
switch.