Skip to content

[SYCL] List unsupported platforms in sycl-ls verbose mode #15166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 5, 2024

Conversation

jchlanda
Copy link
Contributor

The runtime is able to recognised banned platforms, this patch provides a way to list them using sycl-ls' verbose switch.

@jchlanda jchlanda requested review from a team as code owners August 22, 2024 12:08
@jchlanda jchlanda requested a review from againull August 22, 2024 12:08
@jchlanda
Copy link
Contributor Author

This was suggested a while back, here: #6878 (comment)

@jchlanda jchlanda closed this Aug 23, 2024
@jchlanda jchlanda reopened this Aug 23, 2024
@jchlanda
Copy link
Contributor Author

jchlanda commented Sep 2, 2024

@dm-vodopyanov @al42and would you like me to do anything else for this patch?

@dm-vodopyanov
Copy link
Contributor

@dm-vodopyanov @al42and would you like me to do anything else for this patch?

Thanks, nothing from my side.

@jchlanda
Copy link
Contributor Author

jchlanda commented Sep 3, 2024

@intel/llvm-gatekeepers this should be ready to go.

Thank you!

@dm-vodopyanov
Copy link
Contributor

@intel/llvm-gatekeepers this should be ready to go.

Thank you!

@jchlanda, we need a review from @intel/unified-runtime-reviewers:

image

@jchlanda
Copy link
Contributor Author

jchlanda commented Sep 3, 2024

@intel/llvm-gatekeepers this should be ready to go.
Thank you!

@jchlanda, we need a review from @intel/unified-runtime-reviewers:

image

My bad sorry, was a bit too hasty with this one.

@intel/unified-runtime-reviewers would you be so kind and take a look at this, thank you.

@dm-vodopyanov dm-vodopyanov changed the title [SYCL] List banned platforms in sycl-ls verbose mode [SYCL] List unsupported platforms in sycl-ls verbose mode Sep 3, 2024
@jchlanda
Copy link
Contributor Author

jchlanda commented Sep 5, 2024

@intel/llvm-gatekeepers we've got all the approvals now, should be ready to go.

Thank you!

@martygrant martygrant merged commit 4443eff into intel:sycl Sep 5, 2024
13 checks passed
@steffenlarsen
Copy link
Contributor

@jchlanda - It looks like this made Plugin/sycl-ls.cpp fail on the HIP machine in post-commit. Could you please have a look?

@jchlanda
Copy link
Contributor Author

jchlanda commented Sep 6, 2024

@jchlanda - It looks like this made Plugin/sycl-ls.cpp fail on the HIP machine in post-commit. Could you please have a look?

Yeap, on it.

/// Returns all unsupported (non-SYCL) platforms in the system.
///
/// \return a vector of all unsupported non-SYCL platforms.
static std::vector<platform> get_unsupported_platforms();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jchlanda - Sorry for the post-commit review, but I think we need to reconsider the design of this. This function is now a public interface of a SYCL class, but is not part of neither the standard nor an extension. We either need an extension written for this, or we need it hidden, either in the detail namespace, by making it private or both.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback, on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants