Skip to content

[SYCL] Discard unsupported platforms output in sycl-ls test #15311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

jchlanda
Copy link
Contributor

@jchlanda jchlanda commented Sep 6, 2024

Make sure that the devices that belong to unsupported platforms are not counted, this is required to match the number of devices when sycl-ls is run in and out of the verbose mode.

@jchlanda jchlanda requested a review from a team as a code owner September 6, 2024 11:11
@jchlanda
Copy link
Contributor Author

jchlanda commented Sep 6, 2024

This patch fixes a post-commit issue discovered here: #15166 (comment)

@sarnex
Copy link
Contributor

sarnex commented Sep 6, 2024

@intel/unified-runtime-reviewers Ping on this one, it will fix postcommit :)

@jchlanda
Copy link
Contributor Author

jchlanda commented Sep 9, 2024

@intel/llvm-gatekeepers we should be ready to roll on this one.

Thank you!

@martygrant martygrant merged commit 93ee5b9 into intel:sycl Sep 9, 2024
25 of 26 checks passed
@steffenlarsen
Copy link
Contributor

@jchlanda - For some odd reason, Windows Build seems to be broken after this. It seems to be in building libclc, but I don't understand how this could have affected it. Either way, could you please have a look?

@sarnex
Copy link
Contributor

sarnex commented Sep 9, 2024

The error looks insane, I'm trying a rebuild on a different runner to see if the runner was busted.

@sarnex
Copy link
Contributor

sarnex commented Sep 9, 2024

Nope, failed again here. I'll try to investigate.

@sarnex
Copy link
Contributor

sarnex commented Sep 9, 2024

I'm still looking and @uditagarwal97 is helping. This might be the weirdest one I've seen.

@uditagarwal97
Copy link
Contributor

I'm still looking and @uditagarwal97 is helping. This might be the weirdest one I've seen.

It's fixed now. It was an infrastructure related issue.

@jchlanda
Copy link
Contributor Author

I'm still looking and @uditagarwal97 is helping. This might be the weirdest one I've seen.

It's fixed now. It was an infrastructure related issue.

off the hook :)
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants