-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][OpenCL] Ban AMD OpenCL platform (#5825) #6878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me, but I may not know some plans regarding supported platforms, etc.
@pvchupin can you please assign someone from your team to review this PR?
If OpenCL for AMD GPUs is being problematic, I am okay with giving it the same treatment as we have done for NVIDIA GPUs. @AerialMantis - Is this something you have tested and/or had problems with before? |
May I bump this? OpenCL backend still does not support AMD GPUs as far as I can tell, and listing them among available devices is just confusing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, as far as I'm aware this is also not working, like the Nvidia one, I'm happy to ban it as well for now.
@al42and, could you update your branch, please? I see that it was tested in September last year, I'd like to make sure it still passes the tests. On comment from my side, I think we should discard devices based on features they do not support (e.g. required SPIR-V extension) instead of relying on platform name. This suggestion is better implement in follow-up patches. |
Compiling kernels for it is not supported, device info sometimes throws, and there is HIP backend. Closes intel#5825
0b28502
to
d6dac11
Compare
Rebased on top of the current |
There are other failing GitHub Actions with the same error, so I guess that's not this PRs fault |
In addition to that it can be useful to list discarded devices with |
Compiling kernels for it is not supported, device info sometimes throws, and there is the HIP backend for those wanting to use an AMD GPU.
Closes #5825