[Driver][SYCL] Move include/sycl header before other system header lo… #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cations The location in which the include/sycl headers are added are too late in the ordering sequence. This is causing the possibility of the wrong version of the OpenCL headers to be picked up (i.e. from /usr/include) Improve the ordering by putting the dirs much earlier in the command line instead of relying on the ToolChain addition. Signed-off-by: Michael D Toguchi <michael.d.toguchi@intel.com>
AGindinson
reviewed
Apr 8, 2020
AGindinson
approved these changes
Apr 8, 2020
|
I hope this change would unblock fpga BE as well. Looking forward to it :D! |
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Apr 9, 2020
…duler_docs * origin/sycl: (26 commits) [Driver][SYCL] Move include/sycl header before other system header locations (intel#1492) [BuildBot] Improve usability of buildbot scripts (intel#1472) [NFC] Add GitHub actions badges to README file (intel#1496) [SYCL] Improve error handling for kernel invocation (intel#1209) [SYCL][Driver] Fix SYCL standards' handling for '-fsycl -fsycl-device-only' invocations (intel#1371) [SYCL] Move type checks to later in Semantic Analysis lifecycle (intel#1465) [CI] Download fixed versions of Python tools (intel#1485) [SYCL] Fix sub_group::broadcast (intel#1482) [SYCL][Test] Disable spec_const_redefine.cpp on all devices but HOST (intel#1488) [SYCL] Only export public API (intel#1456) [SYCL][CUDA] Fix selected_binary argument in piextDeviceSelectBinary (intel#1475) [SYCL] Enable LIT testing with CUDA BE (intel#1458) [SYCL] Fix float to half-type conversion (intel#1395) [NFC] Cleanup unneded macro from builtins implementation (intel#1445) Enable cfg-printer LLVM lit tests only if LLVM linked statically (intel#1479) [SYCL][NFC] Reflect the "allowlist" renaming in the code (intel#1480) [SYCL][Doc] Update prerequisites in GetStartedGuide (intel#1466) [SYCL][USM] Remove vestigial dead code (intel#1474) [SYCL-PTX] Fix __spirv_GroupAsyncCopy stride computation (intel#1451) [Driver][SYCL] Emit an error if c compilation is forced (intel#1438) ...
dwoodwor-intel
pushed a commit
to dwoodwor-intel/llvm
that referenced
this pull request
Jun 10, 2022
intel#1492) Translate atomic_fetch_sub to OpAtomicFAddEXT with negative value operand Signed-off-by: Haonan Yang <haonan.yang@intel.com> Original commit: KhronosGroup/SPIRV-LLVM-Translator@583d365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cations
The location in which the include/sycl headers are added are too late in
the ordering sequence. This is causing the possibility of the wrong version
of the OpenCL headers to be picked up (i.e. from /usr/include)
Improve the ordering by putting the dirs much earlier in the command line
instead of relying on the ToolChain addition.
Signed-off-by: Michael D Toguchi michael.d.toguchi@intel.com