Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][Driver] Fix SYCL standards' handling for '-fsycl -fsycl-device-only' invocations #1371

Merged
merged 18 commits into from
Apr 8, 2020
Merged

[SYCL][Driver] Fix SYCL standards' handling for '-fsycl -fsycl-device-only' invocations #1371

merged 18 commits into from
Apr 8, 2020

Conversation

s-kanaev
Copy link
Contributor

No description provided.

Sergey Kanaev added 5 commits March 19, 2020 17:14
[SYCL] Fix '-fsycl-device-only -fsycl' compiler invocation scenario
53f22f3 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Merge branch 'sycl' into private/s-kanaev/fix
58c1404
[SYCL] Preserve original order of cmdline parameters
fa661cc 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
[SYCL] Add test
5511284 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Merge branch 'sycl' into private/s-kanaev/fix
b68b674
AGindinson
AGindinson reviewed Mar 23, 2020
View reviewed changes
Copy link
Contributor

@AGindinson AGindinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I'd prefer to see a more concrete commit message:

[SYCL][Driver] Fix SYCL standards' handling for 'fsycl-device-only' invocations

clang/lib/Driver/ToolChains/Clang.cpp Outdated Show resolved Hide resolved
clang/lib/Driver/ToolChains/Clang.cpp Outdated Show resolved Hide resolved
Sergey Kanaev added 4 commits March 24, 2020 09:53
[SYCL] Fix indentation
04da2a0 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
[SYCL] Add check for -Wno-sycl-strict to nvptx test
8704aeb 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
[SYCL] Fix indentation
5de6d2c 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
[SYCL] Fix indentation
57ad691 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
@s-kanaev s-kanaev requested a review from vladimirlaz March 24, 2020 11:00
[SYCL] Change condition
e4e5caf 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
@AGindinson
Copy link
Contributor

Personally, I'd prefer to see a more concrete commit message:

[SYCL][Driver] Fix SYCL standards' handling for 'fsycl-device-only' invocations

@s-kanaev, what do you think here?

@s-kanaev s-kanaev changed the title [SYCL] Fix '-fsycl-device-only -fsycl' compiler invocation scenario [SYCL][Driver] Fix SYCL standards' handling for '-fsycl -fsycl-device-only' invocations Mar 25, 2020
@s-kanaev
Copy link
Contributor Author

what do you think here?

Done.

@s-kanaev s-kanaev requested a review from AGindinson March 25, 2020 08:16
[SYCL] Rearrange code
82db1fa 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
@s-kanaev s-kanaev force-pushed the private/s-kanaev/fix branch from 1e815fc to 82db1fa Compare March 25, 2020 10:19
@s-kanaev s-kanaev requested a review from AGindinson March 31, 2020 11:21
AGindinson
AGindinson reviewed Mar 31, 2020
View reviewed changes
Copy link
Contributor

@AGindinson AGindinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got the point why a separate IsSYCL check is needed - the UseSYCLTriple I've suggested before indeed wouldn't have covered all cases. Some regression test comments remaining.

clang/test/Driver/sycl-device.cpp Outdated Show resolved Hide resolved
clang/lib/Driver/ToolChains/Clang.cpp Show resolved Hide resolved
@bader
Copy link
Contributor

bader commented Apr 3, 2020

@s-kanaev, could you resolve comments, please?

s-kanaev and others added 2 commits April 6, 2020 10:33
@s-kanaev @AGindinson
[SYCL] Update clang/test/Driver/sycl-device.cpp
91e7213 
Signed-off-by: Sergey Kanaev sergey.kanaev@intel.com

Co-Authored-By: Artem Gindinson <artem.gindinson@intel.com>
[SYCL] Add tests
88e2325 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
AGindinson
AGindinson reviewed Apr 6, 2020
View reviewed changes
clang/test/Driver/sycl.c Outdated Show resolved Hide resolved
@s-kanaev @AGindinson
[SYCL] Update clang/test/Driver/sycl.c
5268837 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>

Co-Authored-By: Artem Gindinson <artem.gindinson@intel.com>
AGindinson
AGindinson previously approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@AGindinson AGindinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@bader
Copy link
Contributor

bader commented Apr 7, 2020

@s-kanaev, please, take a look at failing tests.

Sergey Kanaev added 2 commits April 7, 2020 12:09
Merge branch 'sycl' into private/s-kanaev/fix
a7ecb95
[SYCL] Fix test
a6720fa 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
@s-kanaev
Copy link
Contributor Author

s-kanaev commented Apr 8, 2020

@s-kanaev, please, take a look at failing tests.

Done

@bader bader requested a review from AGindinson April 8, 2020 09:23
@s-kanaev @AGindinson
Update clang/test/Driver/sycl-device.cpp
aa40aa5 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>

Co-Authored-By: Artem Gindinson <artem.gindinson@intel.com>
@bader bader merged commit 7f924a8 into intel:sycl Apr 8, 2020
@s-kanaev s-kanaev deleted the private/s-kanaev/fix branch April 9, 2020 06:42
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Apr 9, 2020
Merge remote-tracking branch 'origin/sycl' into private/abatashe/sche…
0032e53 
…duler_docs

* origin/sycl: (26 commits)
  [Driver][SYCL] Move include/sycl header before other system header locations (intel#1492)
  [BuildBot] Improve usability of buildbot scripts (intel#1472)
  [NFC] Add GitHub actions badges to README file (intel#1496)
  [SYCL] Improve error handling for kernel invocation (intel#1209)
  [SYCL][Driver] Fix SYCL standards' handling for '-fsycl -fsycl-device-only' invocations (intel#1371)
  [SYCL] Move type checks to later in Semantic Analysis lifecycle (intel#1465)
  [CI] Download fixed versions of Python tools (intel#1485)
  [SYCL] Fix sub_group::broadcast (intel#1482)
  [SYCL][Test] Disable spec_const_redefine.cpp on all devices but HOST (intel#1488)
  [SYCL] Only export public API (intel#1456)
  [SYCL][CUDA] Fix selected_binary argument in piextDeviceSelectBinary (intel#1475)
  [SYCL] Enable LIT testing with CUDA BE (intel#1458)
  [SYCL] Fix float to half-type conversion (intel#1395)
  [NFC] Cleanup unneded macro from builtins implementation (intel#1445)
  Enable cfg-printer LLVM lit tests only if LLVM linked statically (intel#1479)
  [SYCL][NFC] Reflect the "allowlist" renaming in the code (intel#1480)
  [SYCL][Doc] Update prerequisites in GetStartedGuide (intel#1466)
  [SYCL][USM] Remove vestigial dead code (intel#1474)
  [SYCL-PTX] Fix __spirv_GroupAsyncCopy stride computation (intel#1451)
  [Driver][SYCL] Emit an error if c compilation is forced (intel#1438)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader left review comments

@AGindinson AGindinson AGindinson approved these changes

@mdtoguchi mdtoguchi Awaiting requested review from mdtoguchi

@vladimirlaz vladimirlaz Awaiting requested review from vladimirlaz

Assignees

@vladimirlaz vladimirlaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@s-kanaev @AGindinson @bader @vladimirlaz