Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BuildBot] Improve usability of buildbot scripts #1472

Merged
merged 4 commits into from
Apr 9, 2020
Merged

Conversation

bader
Copy link
Contributor

@bader bader commented Apr 3, 2020

  1. Make all parameters optional with (hopefully) useful defaults.
  2. Run actions through CMake to make the independent from the build
    system (e.g. Ninja/Makefiles/MSVC/etc.)

Signed-off-by: Alexey Bader alexey.bader@intel.com

bader added 2 commits April 3, 2020 13:00
1. Make all parameters optional with (hopefully) useful defaults.
2. Run actions through CMake to make the independent from the build
system (e.g. Ninja/Makefiles/MSVC/etc.)

Signed-off-by: Alexey Bader <alexey.bader@intel.com>
Signed-off-by: Alexey Bader <alexey.bader@intel.com>
pvchupin
pvchupin previously approved these changes Apr 3, 2020
Copy link
Contributor

@pvchupin pvchupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure all python scripts stay as a very thin layer on top of standard LLVM commands (make/ninja)

buildbot/check.py Outdated Show resolved Hide resolved
buildbot/compile.py Outdated Show resolved Hide resolved
buildbot/configure.py Outdated Show resolved Hide resolved
Signed-off-by: Alexey Bader <alexey.bader@intel.com>

Co-Authored-By: Dmitry Vodopyanov <dmitry.vodopyanov@intel.com>
@bader bader requested a review from pvchupin April 8, 2020 11:08
@dm-vodopyanov dm-vodopyanov self-requested a review April 8, 2020 21:54
@bader bader merged commit 4d34c9b into intel:sycl Apr 9, 2020
@bader bader deleted the buildbot branch April 9, 2020 07:31
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Apr 9, 2020
…duler_docs

* origin/sycl: (26 commits)
  [Driver][SYCL] Move include/sycl header before other system header locations (intel#1492)
  [BuildBot] Improve usability of buildbot scripts (intel#1472)
  [NFC] Add GitHub actions badges to README file (intel#1496)
  [SYCL] Improve error handling for kernel invocation (intel#1209)
  [SYCL][Driver] Fix SYCL standards' handling for '-fsycl -fsycl-device-only' invocations (intel#1371)
  [SYCL] Move type checks to later in Semantic Analysis lifecycle (intel#1465)
  [CI] Download fixed versions of Python tools (intel#1485)
  [SYCL] Fix sub_group::broadcast (intel#1482)
  [SYCL][Test] Disable spec_const_redefine.cpp on all devices but HOST (intel#1488)
  [SYCL] Only export public API (intel#1456)
  [SYCL][CUDA] Fix selected_binary argument in piextDeviceSelectBinary (intel#1475)
  [SYCL] Enable LIT testing with CUDA BE (intel#1458)
  [SYCL] Fix float to half-type conversion (intel#1395)
  [NFC] Cleanup unneded macro from builtins implementation (intel#1445)
  Enable cfg-printer LLVM lit tests only if LLVM linked statically (intel#1479)
  [SYCL][NFC] Reflect the "allowlist" renaming in the code (intel#1480)
  [SYCL][Doc] Update prerequisites in GetStartedGuide (intel#1466)
  [SYCL][USM] Remove vestigial dead code (intel#1474)
  [SYCL-PTX] Fix __spirv_GroupAsyncCopy stride computation (intel#1451)
  [Driver][SYCL] Emit an error if c compilation is forced (intel#1438)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants