[SYCL] Use sycl/detail/core.hpp in test-e2e/UserDefinedReductions/*
#13841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continuation of changes started in intel#12890.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
Depends on #13839 (somehow) and has to be merged after it. |
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
reviewed
May 20, 2024
| @@ -9,6 +9,7 @@ | |||
| #pragma once | |||
|
|
|||
| #include <sycl/detail/defines.hpp> | |||
| #include <sycl/ext/oneapi/experimental/group_helpers_sorters.hpp> | |||
There was a problem hiding this comment.
I'm most likely missing something, why we need to include this header for sorting algorithms into reductions header?
There was a problem hiding this comment.
group_with_scratchpad is defined in the sorting extension, UDR extension depends on that one for it. It's not really required for the implementation, but it is needed for the user to use UDR extension, so we should be providing it as part of this include.
againull
approved these changes
May 20, 2024
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bso-intel
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of changes started in #12890.