[NFC][SYCL] Include sycl/feature_test.hpp in sycl/detail/core.hpp
#13839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-functional because it has been there transitively from `sycl/ext/oneapi/sub_group_mask.hpp`. Make that inclusion explicit so that it would remain there in future even if we will decouple that extension out of "core".
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
approved these changes
May 20, 2024
|
CUDA testing passed in https://github.com/intel/llvm/actions/runs/9164861436, the new pending task is caused by the rerun of AMD HIP testing (first run had some random failures so I did a re-run to ensure they're unrelated). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-functional because it has been there transitively from
sycl/ext/oneapi/sub_group_mask.hpp. Make that inclusion explicit so that it would remain there in future even if we will decouple that extension out of "core".