Skip to content

[SYCL] Use sycl/detail/core.hpp in test-e2e/UserDefinedReductions/* #13841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2024
Merged

[SYCL] Use sycl/detail/core.hpp in test-e2e/UserDefinedReductions/* #13841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sycl/include/sycl/ext/oneapi/experimental/user_defined_reductions.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#pragma once

#include <sycl/detail/defines.hpp>
#include <sycl/ext/oneapi/experimental/group_helpers_sorters.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm most likely missing something, why we need to include this header for sorting algorithms into reductions header?

Copy link
Contributor Author

@aelovikov-intel aelovikov-intel May 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

group_with_scratchpad is defined in the sorting extension, UDR extension depends on that one for it. It's not really required for the implementation, but it is needed for the user to use UDR extension, so we should be providing it as part of this include.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks!

#include <sycl/group_algorithm.hpp>

namespace sycl {
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/UserDefinedReductions/user_defined_reductions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
#include <complex>
#include <numeric>

#include <sycl/detail/core.hpp>
#include <sycl/ext/oneapi/experimental/user_defined_reductions.hpp>
#include <sycl/sycl.hpp>

template <typename T> struct UserDefinedSum {
T operator()(T a, T b) { return a + b; }
Expand Down
2 changes: 1 addition & 1 deletion .../test-e2e/UserDefinedReductions/user_defined_reductions_wg_size_larger_than_data_size.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
#include <iostream>
#include <numeric>

#include <sycl/detail/core.hpp>
#include <sycl/ext/oneapi/experimental/user_defined_reductions.hpp>
#include <sycl/sycl.hpp>

// 1. Allocate an buffer of 16 elements where first 8 elements filled with 1,
// ..., 8 and the second 8 elements filled with 0.
Expand Down
Loading