Update IMEX/LLVM versions #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dchigarev <dmitry.chigarev@intel.com>
Signed-off-by: dchigarev <dmitry.chigarev@intel.com>
dchigarev
force-pushed
the
dchigarev/new-imex
branch
from
93754dc to
3f5c79b
Compare
dchigarev
commented
Oct 29, 2024
Comment on lines
-767
to
+769
| packedAttr = mlir::UnitAttr::get(rewriter.getContext()); | ||
| if (!transpose_bit) { | ||
| packedAttr = mlir::UnitAttr::get(rewriter.getContext()); | ||
| } |
There was a problem hiding this comment.
Specifying both transpose_bit and packed in xegpu.load_nd is no longer supported. If transpose_bit is specified then the op already behaves as if packed was set.
dchigarev
commented
Oct 29, 2024
Comment on lines
-1168
to
1170
| VnniConfig vnniConfA{.vnniFactor = vnniFactor, .vnniAxis = 1}; | ||
| VnniConfig vnniConfB{.vnniFactor = vnniFactor, .vnniAxis = 0}; |
There was a problem hiding this comment.
xegpu.dpas no longer supports A arguments to be a 3D vector
dchigarev
commented
Oct 29, 2024
Comment on lines
-1632
to
+1634
| LinalgToXeGPUOptions options{kTile, stages, dpasTile}; | ||
| LinalgToXeGPUOptions options{ | ||
| kTile, stages, SmallVector<int64_t>(dpasTile.begin(), dpasTile.end())}; |
There was a problem hiding this comment.
Does the conversion explicitly
error: could not convert ‘dpasTile’ from ‘mlir::Pass::ListOption<long int>’ to ‘llvm::SmallVector<long int>’
kurapov-peter
approved these changes
Oct 29, 2024
AndreyPavlenko
approved these changes
Oct 29, 2024
Signed-off-by: dchigarev <dmitry.chigarev@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #392
This PR adapts GC to the new version on IMEX&LLVM.
The "new version of imex" is the
mlir-extension/gc-stagingbranch that was rebased ontomlir-extensions/main. The rebasedgc-stagingbranch lives in my own fork for now.How I'm planing to merge this:
dchigarev/mlir-extensions/gc-staging-2branch intomlir-extensions/gc-staging----- CI in GC is broken at this point, since it'll try to fetch commits from
gc-stagingthat no longer exist -----cmake/imex-version.txtin this PR (Update IMEX/LLVM versions #399) to point to the new head ofmlir-extensions/gc-staging.If someone has a better suggestion on how to do it better, I'll be glad to hear it