Skip to content

Conversation

@wiedld
Copy link

@wiedld wiedld commented Jan 8, 2025

This takes us up to Dec-4 SHA c510ab4

It advances DF by adding these Nov-20 to Dec-4 commits: a2811fc...influxdata:arrow-datafusion:c510ab46fcb1148052bb8999e423360b4c17ecdf

Change in patches:

Removed 5 patches:

  • Screenshot 2025-01-08 at 9 33 50 AM

Add 1 patch (which will fall off with next DF upgrade):

  • Screenshot 2025-01-08 at 9 32 27 AM

Patches applied:

  • Patches already fixed in future upstream commits:

  • Patches still not fixed:

  • Patches specific to our DF branch (no need for upstream fix):

    • we are keeping in the warn logging for the schema mismatch. (Upstream only returns error, or not, based on schema misalignment): our patch 69d6118

@github-actions github-actions bot added documentation Improvements or additions to documentation sqllogictest core physical-expr common labels Jan 8, 2025
alamb and others added 6 commits January 7, 2025 18:56
…SanityCheck plan patch (to turn it off) makes the output result sort nondeterministic
* Increase minimum supported Rust version (MSRV) to 1.80.1

We currently require 1.80, but we also say that

> If a hotfix is released for the minimum supported Rust version (MSRV),
> the MSRV will be the minor version with all hotfixes

therefore we should requite 1.80.1 and thus allow dependencies that
require 1.80.1 (such as substrait)

* Revert "fix: cargo msrv check failed (apache#13654)"

This reverts commit c510ab4.
@alamb
Copy link
Collaborator

alamb commented Jan 8, 2025

I'm not sure when we can stop skipping the SanityCheckPlan. I'm unclear how it relates to the additional sort pushdown fixes, including a recent fix done 3 weeks ago

As I understand it, the idea is we will catch up with updates and then once that is completed, we will work on removing our patches. I am actively working on

It sounds like there may be some additional work for the other patches as well

@wiedld
Copy link
Author

wiedld commented Jan 16, 2025

Closed as no longer used.

@wiedld wiedld closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants