fix: cargo msrv check failed #13654
Merged
fix: cargo msrv check failed #13654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Dec 5, 2024
korowa
approved these changes
Dec 5, 2024
Contributor
|
LGTM, thank you @jonahgao |
findepi
added a commit
to findepi/datafusion
that referenced
this pull request
Dec 5, 2024
This reverts commit c510ab4.
findepi
added a commit
to findepi/datafusion
that referenced
this pull request
Dec 5, 2024
This reverts commit c510ab4.
comphead
pushed a commit
that referenced
this pull request
Dec 5, 2024
* Increase minimum supported Rust version (MSRV) to 1.80.1 We currently require 1.80, but we also say that > If a hotfix is released for the minimum supported Rust version (MSRV), > the MSRV will be the minor version with all hotfixes therefore we should requite 1.80.1 and thus allow dependencies that require 1.80.1 (such as substrait) * Revert "fix: cargo msrv check failed (#13654)" This reverts commit c510ab4.
zhuliquan
pushed a commit
to zhuliquan/datafusion
that referenced
this pull request
Dec 6, 2024
* fix: cargo msrv check failed * Update comment
wiedld
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Jan 6, 2025
* Increase minimum supported Rust version (MSRV) to 1.80.1 We currently require 1.80, but we also say that > If a hotfix is released for the minimum supported Rust version (MSRV), > the MSRV will be the minor version with all hotfixes therefore we should requite 1.80.1 and thus allow dependencies that require 1.80.1 (such as substrait) * Revert "fix: cargo msrv check failed (apache#13654)" This reverts commit c510ab4.
wiedld
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Jan 8, 2025
* fix: cargo msrv check failed * Update comment
wiedld
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Jan 8, 2025
* Increase minimum supported Rust version (MSRV) to 1.80.1 We currently require 1.80, but we also say that > If a hotfix is released for the minimum supported Rust version (MSRV), > the MSRV will be the minor version with all hotfixes therefore we should requite 1.80.1 and thus allow dependencies that require 1.80.1 (such as substrait) * Revert "fix: cargo msrv check failed (apache#13654)" This reverts commit c510ab4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13653.
Rationale for this change
substrait@0.49.5 uses a higher MSRV 1.80.1.
Changelog
This PR restricts substrait‘s version to 0.49.4 to ensure compatibility with the current DataFusion MSRV.
What changes are included in this PR?
Are these changes tested?
Yes. By CI.
Are there any user-facing changes?
No