-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Increase minimum supported Rust version (MSRV) to 1.80.1 #13667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently require 1.80, but we also say that > If a hotfix is released for the minimum supported Rust version (MSRV), > the MSRV will be the minor version with all hotfixes therefore we should requite 1.80.1 and thus allow dependencies that require 1.80.1 (such as substrait)
This reverts commit c510ab4.
mbrobbel
approved these changes
Dec 5, 2024
jonahgao
approved these changes
Dec 5, 2024
Member
jonahgao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @findepi 👍. We should use version 1.80.1, which includes bug fixes.
Do we also need to update the Dockerfile?
Contributor
Member
Author
|
wiedld
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Jan 6, 2025
* Increase minimum supported Rust version (MSRV) to 1.80.1 We currently require 1.80, but we also say that > If a hotfix is released for the minimum supported Rust version (MSRV), > the MSRV will be the minor version with all hotfixes therefore we should requite 1.80.1 and thus allow dependencies that require 1.80.1 (such as substrait) * Revert "fix: cargo msrv check failed (apache#13654)" This reverts commit c510ab4.
wiedld
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Jan 8, 2025
* Increase minimum supported Rust version (MSRV) to 1.80.1 We currently require 1.80, but we also say that > If a hotfix is released for the minimum supported Rust version (MSRV), > the MSRV will be the minor version with all hotfixes therefore we should requite 1.80.1 and thus allow dependencies that require 1.80.1 (such as substrait) * Revert "fix: cargo msrv check failed (apache#13654)" This reverts commit c510ab4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
core
Core DataFusion crate
development-process
Related to development process of DataFusion
proto
Related to proto crate
substrait
Changes to the substrait crate
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
We currently require 1.80, but we also say that
therefore we should requite 1.80.1 and thus allow dependencies that
require 1.80.1 (such as substrait)
What changes are included in this PR?
Are these changes tested?
existing tests
Are there any user-facing changes?
1.80.0 is no longer supported
relates to