Skip to content

Conversation

@findepi
Copy link
Member

@findepi findepi commented Dec 5, 2024

Which issue does this PR close?

Rationale for this change

We currently require 1.80, but we also say that

If a hotfix is released for the minimum supported Rust version (MSRV),
the MSRV will be the minor version with all hotfixes

therefore we should requite 1.80.1 and thus allow dependencies that
require 1.80.1 (such as substrait)

What changes are included in this PR?

  • require 1.80.1 msrv

Are these changes tested?

existing tests

Are there any user-facing changes?

1.80.0 is no longer supported

relates to

@github-actions github-actions bot added the substrait Changes to the substrait crate label Dec 5, 2024
@findepi findepi changed the title Findepi/msrv Increase minimum supported Rust version (MSRV) to 1.80.1 Dec 5, 2024
We currently require 1.80, but we also say that

> If a hotfix is released for the minimum supported Rust version (MSRV),
> the MSRV will be the minor version with all hotfixes

therefore we should requite 1.80.1 and thus allow dependencies that
require 1.80.1 (such as substrait)
@github-actions github-actions bot added development-process Related to development process of DataFusion core Core DataFusion crate proto Related to proto crate labels Dec 5, 2024
@findepi findepi requested review from alamb and jonahgao December 5, 2024 15:45
Copy link
Member

@jonahgao jonahgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @findepi 👍. We should use version 1.80.1, which includes bug fixes.
Do we also need to update the Dockerfile?

@comphead
Copy link
Contributor

comphead commented Dec 5, 2024

Thanks @findepi
I should probably have made a policy slightly more clear to mention the hotfix related to rust compiler.

#13668

@findepi
Copy link
Member Author

findepi commented Dec 5, 2024

Do we also need to update the Dockerfile?

rust:1.80-bookworm ships rustc 1.80.1

@comphead comphead merged commit 2464703 into apache:main Dec 5, 2024
27 checks passed
@findepi findepi deleted the findepi/msrv branch December 5, 2024 17:32
wiedld pushed a commit to influxdata/arrow-datafusion that referenced this pull request Jan 6, 2025
* Increase minimum supported Rust version (MSRV) to 1.80.1

We currently require 1.80, but we also say that

> If a hotfix is released for the minimum supported Rust version (MSRV),
> the MSRV will be the minor version with all hotfixes

therefore we should requite 1.80.1 and thus allow dependencies that
require 1.80.1 (such as substrait)

* Revert "fix: cargo msrv check failed (apache#13654)"

This reverts commit c510ab4.
wiedld pushed a commit to influxdata/arrow-datafusion that referenced this pull request Jan 8, 2025
* Increase minimum supported Rust version (MSRV) to 1.80.1

We currently require 1.80, but we also say that

> If a hotfix is released for the minimum supported Rust version (MSRV),
> the MSRV will be the minor version with all hotfixes

therefore we should requite 1.80.1 and thus allow dependencies that
require 1.80.1 (such as substrait)

* Revert "fix: cargo msrv check failed (apache#13654)"

This reverts commit c510ab4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate development-process Related to development process of DataFusion proto Related to proto crate substrait Changes to the substrait crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants