Repository navigation
[codex] fix auto-merge when no review is required - #101
Merged
Merged
Conversation
inferjay
marked this pull request as ready for review
October 9, 2026 06:38
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The first live run after #98 created Android downloads PR #100 and passed the offline tests, generated-page guard, and Cloudflare Pages check, but its merge step stopped with
The PR requires review before merging.Root cause:
gh pr view --json reviewDecisionreturns an empty string ("") when no review decision is required. The gate only acceptednullorAPPROVED, so it misclassified the empty string as a review requirement.gh-pageshas no branch protection or active branch rules requiring a review.Change
Accept
""as the no-review state, while continuing to blockREVIEW_REQUIREDand other non-approved decisions. Add a regression test for the exact value seen in the live run.Verification
python3 -m unittest discover -s tests -v— 33 tests passed.git diff --check— passed.This PR does not merge #100. Once the fix is approved and merged into
master, rerun the update workflow onmasterto verify the full auto-merge path.