Merge pull request #101 from inferjay/codex/fix-auto-merge-review-decision

[codex] fix auto-merge when no review is required

Author: inferjay

scripts/auto_merge_android_download_pr.py

@@ -110,7 +110,7 @@ def merge_verified_pr(repo: str, number: int, head_sha: str, base_sha: str, *, a
 
     _validate_pr(_get_json(pr_endpoint), _get_json(files_endpoint), repo, head_sha)
     _validate_base_ref(repo, base_sha)
-    if _review_decision(repo, number) not in (None, "APPROVED"):
+    if _review_decision(repo, number) not in (None, "", "APPROVED"):
         raise MergeBlocked("The PR requires review before merging")
     _merge(repo, number, head_sha)
 

tests/test_auto_merge_android_download_pr.py

@@ -82,6 +82,10 @@ def test_merges_verified_bot_pr_after_cloudflare_success(self) -> None:
         merge.assert_called_once_with(REPO, 123, HEAD)
         sleep.assert_not_called()
 
+    def test_merges_when_no_review_is_required(self) -> None:
+        merge, _ = self.run_gate(review_decision="")
+        merge.assert_called_once_with(REPO, 123, HEAD)
+
     def test_rejects_pr_from_other_author(self) -> None:
         pr = copy.deepcopy(PR)
         pr["user"]["login"] = "another-user"