Fix #52 conjur logon fail #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AndrewCopeland
commented
Jan 21, 2021
AndrewCopeland
commented
- Make paths OS agnostic
infamousjoeg
requested changes
Jan 27, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
infamousjoeg
approved these changes
Jan 27, 2021
infamousjoeg
added a commit
that referenced
this pull request
Jan 28, 2021
* Do not list unless prompted to list (#21) * Push current README changes for review * Fix typo to resolve issue #23 (#24) * modify the application CMD for authn-<action> (#25) * Fix unit tests (#26) * More than on account in this safe now * Create application used for list authentication test * Safe Members permissions is not an array * If failure to send request do not attempt to get body * fix dev example * Added code of conduct, contributing, updated readme * v0.0.4-alpha * Conjur commands (#27) * Add the conjur-api-go library * CMD for conjur actions * Helper functions for conjur * Upgraded deps * Added comment to GetHomeDirectory() * refactor code and place into pkg. Added list resources cmd * go mod tidy * Refactor duplicate code * Refactor * Rotate api key cmd * ~/.netrc file should have 0400 permissions Co-authored-by: Joe Garcia <joe@joe-garcia.com> * Update conjur.go * Safe members (#29) * Added add-member and remove-member to the safe action * Added add member and remove member to cybr api * Added aliases to actions so plural or singular works * Number of Days will not be omitted when 0 * Dev creating application flow (#34) * Dev creating application flow * preventing globbing using double-quotes * v0.0.5-alpha Ready for Release (#35) * bump release version * Ready for release * remove plural aliases * Add new line to commands #33 (#39) * #38 Add cybr conjur logoff command (#40) * #44 refactor api tests (#45) * Add #37 add verbose v006 (#41) * Added logger to httpjson package * Create logger interface and implement interface for CMD logging * When init pas client also init with logger depending on --verbose flag * Add logger to the PAS apis * Do not log added account password. Implemented secrets in logger that will be scrubed when logging * Scrub the password by creating a new logger with secrets * Fix #42 RADIUS authentication support for push, append, challenge/response modes (#48) * support for radius authentication append, push and challened/response * #30 Unsuspend a user from failed logon attempts (#43) * #30 Unsuspend a user from failed logon attempts * Fix typos in cmd * Use old unsuspend endpoint because it uses username name rather than user ID * HERE'S YOUR SPACE * Add logger to user api pkg * Remove duplicate tests * Implement client.GetLogger() function so null logger cannot be returned * Fix 52 conjur logon fail (#53) * add --self-signed flag to conjur logon * Retrieve the certificate path from the conjurrc file * only retrieve the certificate if self signed is enabled * implement a getLoginClient function * Fix #52 conjur logon fail (#54) * add --self-signed flag to conjur logon * Retrieve the certificate path from the conjurrc file * only retrieve the certificate if self signed is enabled * implement a getLoginClient function * Make files path os-agnostic * increase default --limit to 25 Co-authored-by: Joe Garcia <joe@joe-garcia.com> * Fix #32 add cybr logon --non-interactive (#56) * #49 add account actions (#57) * Add ability to auto generate docs (#61) * Fix #31 users cmds v0.1.0 (#55) * Users API implementation * Where responses and requests should be located * remove unneeded files * Remove add user commands because running into issues * Add CMD to list and delete users * prep for v0.1.0-beta release (#62) * prep for v0.1.0-beta release * Remove docs pkg html files * Update default to 25 in description Co-authored-by: AndrewCopeland <andcope1995@gmail.com> Co-authored-by: Joe Garcia <joe@joe-garcia.com> Co-authored-by: Joe Garcia <infamousjoeg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.