Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.0.5-alpha Ready for Release #35

Merged
merged 3 commits into from
Jan 13, 2021
Merged

v0.0.5-alpha Ready for Release #35

merged 3 commits into from
Jan 13, 2021

Conversation

infamousjoeg
Copy link
Owner

  • Added aliases to commands that could be interpreted as singular or plural
  • Added safe members sub-commands to safes command
  • Added conjur command and frequently used sub-commands
  • Added automated application identity bash script to dev/ directory as example
  • Updated README to reflect "Swiss Army Knife" CLI instead of PAS REST only

@infamousjoeg infamousjoeg self-assigned this Jan 13, 2021
Copy link
Collaborator

@AndrewCopeland AndrewCopeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a couple comments

cmd/conjur.go Outdated Show resolved Hide resolved
cmd/conjur.go Outdated Show resolved Hide resolved
cmd/safes.go Outdated Show resolved Hide resolved
cmd/safes.go Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@AndrewCopeland AndrewCopeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@infamousjoeg infamousjoeg merged commit 33706b4 into dev Jan 13, 2021
@infamousjoeg infamousjoeg deleted the prep-v005-alpha branch January 13, 2021 15:45
infamousjoeg added a commit that referenced this pull request Jan 13, 2021
* Do not list unless prompted to list (#21)

* Push current README changes for review

* Fix typo to resolve issue #23 (#24)

* modify the application CMD for authn-<action> (#25)

* Fix unit tests (#26)

* More than on account in this safe now

* Create application used for list authentication test

* Safe Members permissions is not an array

* If failure to send request do not attempt to get body

* fix dev example

* Added code of conduct, contributing, updated readme

* v0.0.4-alpha

* Conjur commands (#27)

* Add the conjur-api-go library

* CMD for conjur actions

* Helper functions for conjur

* Upgraded deps

* Added comment to GetHomeDirectory()

* refactor code and place into pkg. Added list resources cmd

* go mod tidy

* Refactor duplicate code

* Refactor

* Rotate api key cmd

* ~/.netrc file should have 0400 permissions

Co-authored-by: Joe Garcia <joe@joe-garcia.com>

* Update conjur.go

* Safe members (#29)

* Added add-member and remove-member to the safe action

* Added add member and remove member to cybr api

* Added aliases to actions so plural or singular works

* Number of Days will not be omitted when 0

* Dev creating application flow (#34)

* Dev creating application flow

* preventing globbing using double-quotes

* v0.0.5-alpha Ready for Release (#35)

* bump release version

* Ready for release

* remove plural aliases

Co-authored-by: Andrew Copeland <50109276+AndrewCopeland@users.noreply.github.com>
Co-authored-by: AndrewCopeland <andcope1995@gmail.com>
infamousjoeg added a commit that referenced this pull request Jan 28, 2021
* Do not list unless prompted to list (#21)

* Push current README changes for review

* Fix typo to resolve issue #23 (#24)

* modify the application CMD for authn-<action> (#25)

* Fix unit tests (#26)

* More than on account in this safe now

* Create application used for list authentication test

* Safe Members permissions is not an array

* If failure to send request do not attempt to get body

* fix dev example

* Added code of conduct, contributing, updated readme

* v0.0.4-alpha

* Conjur commands (#27)

* Add the conjur-api-go library

* CMD for conjur actions

* Helper functions for conjur

* Upgraded deps

* Added comment to GetHomeDirectory()

* refactor code and place into pkg. Added list resources cmd

* go mod tidy

* Refactor duplicate code

* Refactor

* Rotate api key cmd

* ~/.netrc file should have 0400 permissions

Co-authored-by: Joe Garcia <joe@joe-garcia.com>

* Update conjur.go

* Safe members (#29)

* Added add-member and remove-member to the safe action

* Added add member and remove member to cybr api

* Added aliases to actions so plural or singular works

* Number of Days will not be omitted when 0

* Dev creating application flow (#34)

* Dev creating application flow

* preventing globbing using double-quotes

* v0.0.5-alpha Ready for Release (#35)

* bump release version

* Ready for release

* remove plural aliases

* Add new line to commands #33 (#39)

* #38 Add cybr conjur logoff command (#40)

* #44 refactor api tests (#45)

* Add #37 add verbose v006 (#41)

* Added logger to httpjson package

* Create logger interface and implement interface for CMD logging

* When init pas client also init with logger depending on --verbose flag

* Add logger to the PAS apis

* Do not log added account password. Implemented secrets in logger that will be scrubed when logging

* Scrub the password by creating a new logger with secrets

* Fix #42 RADIUS authentication support for push, append, challenge/response modes (#48)

* support for radius authentication append,  push and challened/response

* #30 Unsuspend a user from failed logon attempts (#43)

* #30 Unsuspend a user from failed logon attempts

* Fix typos in cmd

* Use old unsuspend endpoint because it uses username name rather than user ID

* HERE'S YOUR SPACE

* Add logger to user api pkg

* Remove duplicate tests

* Implement client.GetLogger() function so null logger cannot be returned

* Fix 52 conjur logon fail (#53)

* add --self-signed flag to conjur logon

* Retrieve the certificate path from the conjurrc file

* only retrieve the certificate if self signed is enabled

* implement a getLoginClient function

* Fix #52 conjur logon fail (#54)

* add --self-signed flag to conjur logon

* Retrieve the certificate path from the conjurrc file

* only retrieve the certificate if self signed is enabled

* implement a getLoginClient function

* Make files path os-agnostic

* increase default --limit to 25

Co-authored-by: Joe Garcia <joe@joe-garcia.com>

* Fix #32 add cybr logon --non-interactive (#56)

* #49 add account actions (#57)

* Add ability to auto generate docs (#61)

* Fix #31 users cmds v0.1.0 (#55)

* Users API implementation

* Where responses and requests should be located

* remove unneeded files

* Remove add user commands because running into issues

* Add CMD to list and delete users

* prep for v0.1.0-beta release (#62)

* prep for v0.1.0-beta release

* Remove docs pkg html files

* Update default to 25 in description

Co-authored-by: AndrewCopeland <andcope1995@gmail.com>

Co-authored-by: Joe Garcia <joe@joe-garcia.com>
Co-authored-by: Joe Garcia <infamousjoeg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants