Skip to content

Conversation

@ilgooz
Copy link
Member

@ilgooz ilgooz commented Jul 22, 2021

depends on tendermint/spm-extras#1, tendermint/spm#2.

we also need to make release for spm and spm-extras.

and go mod tidy this PR after.

@ilgooz ilgooz requested review from Pantani, fadeev and lumtis as code owners July 22, 2021 08:57
@ilgooz ilgooz marked this pull request as draft July 22, 2021 08:57
@ilgooz ilgooz linked an issue Jul 22, 2021 that may be closed by this pull request
@ilgooz ilgooz changed the base branch from develop to hotfix/0.17.1 July 22, 2021 12:30
@ilgooz ilgooz force-pushed the refactor/tpl-wasm branch from dd5431a to 5f7a656 Compare July 22, 2021 12:36
@ilgooz ilgooz marked this pull request as ready for review July 22, 2021 14:24
Copy link
Contributor

@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why tests failed, but this worked for me! Was able to install with curl | bash.

https://github.com/fadeev/mars/actions/runs/1058454738

@fadeev fadeev self-requested a review July 23, 2021 06:33
@fadeev
Copy link
Contributor

fadeev commented Jul 23, 2021

Actually, no

~/mars % starport c serve
Cosmos SDK's version is: Stargate v0.40.0 (or later)

🛠️  Building proto...
📦 Installing dependencies...
🛠️  Building the blockchain...
💿 Initializing the app...
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x53d41fa]

goroutine 1 [running]:
github.com/tendermint/spm/cosmoscmd.initRootCmd.func1(0xc000f01180)
	/Users/fadeev/go/pkg/mod/github.com/tendermint/spm@v0.1.1/cosmoscmd/root.go:203 +0x3a
github.com/cosmos/cosmos-sdk/server.AddCommands(0xc000ebc500, 0xc000190ed0, 0x13, 0xc000e7d360, 0xc000e7d3b0, 0xc000de3050)
	/Users/fadeev/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.42.6/server/util.go:262 +0x14b
github.com/tendermint/spm/cosmoscmd.initRootCmd(0xc000ebc500, 0x5cbba88, 0xc0001a13f8, 0x5cca0b8, 0xc000edc020, 0x5cc14d8, 0xc000eb4600, 0xc000123018, 0xc000190ed0, 0x13, ...)
	/Users/fadeev/go/pkg/mod/github.com/tendermint/spm@v0.1.1/cosmoscmd/root.go:196 +0x48b
github.com/tendermint/spm/cosmoscmd.NewRootCmd(0x5759207, 0x4, 0x575aecd, 0x6, 0xc000190ed0, 0x13, 0x5759207, 0x4, 0xc000eb9b90, 0x5ab3f68, ...)
	/Users/fadeev/go/pkg/mod/github.com/tendermint/spm@v0.1.1/cosmoscmd/root.go:148 +0x646
main.main()
	/Users/fadeev/mars/cmd/marsd/main.go:12 +0xac
: exit status 2

@ilgooz
Copy link
Member Author

ilgooz commented Jul 23, 2021

fixed 👍

Copy link
Contributor

@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ilgooz ilgooz merged commit 2d27589 into hotfix/0.17.1 Jul 23, 2021
@ilgooz ilgooz deleted the refactor/tpl-wasm branch July 23, 2021 16:15
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
* refactor(templates): use wasm from tendermint/spm-extras

* Update starport/templates/module/import/stargate.go

* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

might_release GH action fails

4 participants