- 
                Notifications
    You must be signed in to change notification settings 
- Fork 570
refactor(templates): use wasm from tendermint/spm-extras #1399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    ilgooz
  
              
              commented
              
                  
                    Jul 22, 2021 
                  
              
              
            
            
dd5431a    to
    5f7a656      
    Compare
  
    
              
                    fadeev
  
              
              approved these changes
              
                  
                    Jul 23, 2021 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why tests failed, but this worked for me! Was able to install with curl | bash.
| Actually, no  | 
| fixed 👍 | 
              
                    fadeev
  
              
              approved these changes
              
                  
                    Jul 23, 2021 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
              
                    lumtis
  
              
              approved these changes
              
                  
                    Jul 23, 2021 
                  
              
              
            
            
    
  Jchicode 
      pushed a commit
        to Jchicode/cli
      that referenced
      this pull request
    
      Aug 9, 2023 
    
    
      
  
    
      
    
  
* refactor(templates): use wasm from tendermint/spm-extras * Update starport/templates/module/import/stargate.go * fix * fix
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
depends on tendermint/spm-extras#1, tendermint/spm#2.
we also need to make release for spm and spm-extras.
and go mod tidy this PR after.