`might_release` GH action fails

[fadeev]

Describe the bug
https://github.com/fadeev/mars/runs/3082702956

To Reproduce

1. Scaffold a new chain
2. Push it to GitHub
3. Wait for the might_release action to fail

Please provide output of commands

• starport version: starport version v0.17.0 darwin/amd64 -build date: 2021-07-15T18:34:28Z
• go version: go version go1.16 darwin/amd64
• uname -a: Darwin system.local 20.5.0 Darwin Kernel Version 20.5.0: Sat May 8 05:10:33 PDT 2021; root:xnu-7195.121.3~9/RELEASE_X86_64 x86_64

[ilgooz]

Does it work when you run starport serve on your darwin for fadeev/mars?

[fadeev]

Well, yes, it's a vanilla Starport chain just scaffolded with v0.17.

[ilgooz]

wasvm depends on gcc and cross compilation is not strightforward when it's enabled. therefore, I think wasm users won't be able to benefit from the c build --release feature.

[fadeev]

Well, then I suppose we need to make sure that a chain scaffolded by Starport (Wasm-less) successfully gets released. As discussed, one option could be to scaffold with the no-wasm branch of spm and switch to wasm branch after running starport s wasm.

[ilgooz]

I think we should just create another repo for wasm called tendermint/spmwasm. So, we don't get to manage multiple branches and releases for spm. cc @lubtd @Pantani

[lumtis]

I think we should just create another repo for wasm called tendermint/spmwasm. So, we don't get to manage multiple branches and releases for spm. cc @lubtd @Pantani

What would you have in this repo? Is it the exact same package but without wasm? I don't see how it is better, we will have several repo to maintain instead of several branch.
With several branches, we just need to merge master into no-wasm when we make a change into spm

[ilgooz]

No, not the same package, only to put wasm related logic.

[lumtis]

No, not the same package, only to put wasm related logic.

Ok I see although we currently depend on wasm functionality in the general initRootCmd method, we must see if those can be put outside:
https://github.com/tendermint/spm/blob/42e72ad05b63df369b679d64e8cfedaea15ba1c9/cosmoscmd/root.go#L195
https://github.com/tendermint/spm/blob/42e72ad05b63df369b679d64e8cfedaea15ba1c9/cosmoscmd/root.go#L184

[lumtis]

Also I would rather call the package cmdwasm because it would basically allows to add wasm related cmd to your app

[fadeev]

Fixed in #1399