Skip to content

feat: add wasmcmd pkg #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2021
Merged

feat: add wasmcmd pkg #1

merged 1 commit into from
Jul 22, 2021

Conversation

@ilgooz
Copy link
Member

@ilgooz ilgooz commented Jul 22, 2021

derived from tendermint/spm with some modifications.

@ilgooz ilgooz requested review from Pantani, fadeev and lumtis July 22, 2021 08:38
ilgooz added a commit to tendermint/spm that referenced this pull request Jul 22, 2021
@ilgooz
refactor: moved wasm logic to tendermint/spm-extras
4c1c3db 
tendermint/spm-extras#1.
This was referenced Jul 22, 2021
Merged
Merged
lumtis
lumtis approved these changes Jul 22, 2021
View reviewed changes
Copy link

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but we should rename the entire repo into wasmcmd.

spm-extras description says

Additional packages that we can not keep under tendermint/spm because of incompatibility issues.

but if we eventually have another incompatibility with go.mod then we would even create another repo to keep this incompatibility separated apart as we did here for wasm

Or at least renaming it to spm-wasm to precise this will be all the stuff when you can import wasm

@ilgooz
Copy link
Member Author

ilgooz commented Jul 22, 2021

I believe it is better to keep this generic name for future proofing, one repo would be enough.

@ilgooz ilgooz merged commit de32058 into master Jul 22, 2021
@ilgooz ilgooz deleted the feat/wasmcmd branch July 22, 2021 12:43
@fadeev
Copy link

fadeev commented Jul 22, 2021

We may rename things in the future. As long as users are able to install older versions, it should be fine.

@lumtis
Copy link

lumtis commented Jul 22, 2021

I believe it is better to keep this generic name for future proofing, one repo would be enough.

There is no reason to keep a generic name if this has been specifically created for wasm

We may rename things in the future. As long as users are able to install older versions, it should be fine.

This is not a no go, it just makes the repo name less descriptive IMO

ilgooz added a commit to tendermint/spm that referenced this pull request Jul 22, 2021
@ilgooz
refactor: moved wasm logic to tendermint/spm-extras (#2)
5d2bdfa 
tendermint/spm-extras#1.
ilgooz added a commit to ignite/cli that referenced this pull request Jan 6, 2022
@ilgooz @lumtis
@Pantani @jhernandezb @alijnmerchant21
chore: merge tendermint/spm/* into starport/pkg (#1968)
d8541ed 
* init & add openapiconsole pkg

* feat: add cosmoscmd package (tendermint/spm#1)

* go mod init =

* genaccounts

* genwasm

* Cosmos app

* Encoding

* Prefix

* gosum

* Init gitignore

* root

* Make types public

* add imports

* Organize imports

* Lint

* Rename to cosmoscmd

* Simplification

* Remove blank line

* refactor: moved wasm logic to tendermint/spm-extras (tendermint/spm#2)

tendermint/spm-extras#1.

* fix(cosmoscmd): handle nil start cmd customizer (tendermint/spm#3)

* feat(cmd): add config command (tendermint/spm#4)

* chore: add codeowners file (tendermint/spm#5)

* fix(cosmoscmd): detecting home (tendermint/spm#8)

* feat(testutil): add `testutil` pkg to generate sample objects (tendermint/spm#10)

* add testutil pkg to generate sample objects

* add unit test

* feat: upgrade sdk to v0.44.0 (tendermint/spm#13)

* feat(keeper): add`ibckeeper` okg with static methods to avoid scaffold it (tendermint/spm#12)

* creates a new IBC Keeper with static methods to avoid scaffold it

* remove unused parameters

* update ibc keeper to v0.44

* export interface keepers

* fix(cosmoscmd): remove `vesting` from tx command (tendermint/spm#14)

* remove vesting

* Remove additional line break

* feat: add CI tests (tendermint/spm#15)

* add ci test

* remove test coverage

* fix(cosmoscmd): home flag parsing in sdk v0.44.3 (tendermint/spm#16)

* fix(cosmoscmd): home flag parsing in sdk v0.44.3

* bump ibc version

* feat: add ability to change environment variables prefix (tendermint/spm#23)

* fix(cosmoscmd): cli default outputs (tendermint/spm#22)

* docs(tutorials): blog-index-update (tendermint/spm#1961)

* feat(template): add `--no-simulation` flag (tendermint/spm#1938)

* add no simulation flag

* add no simulation flag to scaffold message command

* move the simulation modifier function to inside the no simulation condition

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>

* fix merge

* fix pkg names

* use rename import for openapiconsole

* fix lint

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Danilo Pantani <danpantani@gmail.com>
Co-authored-by: Jorge Hernández <3452489+jhernandezb@users.noreply.github.com>
Co-authored-by: Aliasgar Merchant <44069404+alijnmerchant21@users.noreply.github.com>
ilgooz added a commit to ignite/cli that referenced this pull request Jan 6, 2022
@ilgooz @lumtis
@Pantani @jhernandezb @alijnmerchant21
chore: merge tendermint/spm/* into starport/pkg (#1968)
50f53d6 
* init & add openapiconsole pkg

* feat: add cosmoscmd package (tendermint/spm#1)

* go mod init =

* genaccounts

* genwasm

* Cosmos app

* Encoding

* Prefix

* gosum

* Init gitignore

* root

* Make types public

* add imports

* Organize imports

* Lint

* Rename to cosmoscmd

* Simplification

* Remove blank line

* refactor: moved wasm logic to tendermint/spm-extras (tendermint/spm#2)

tendermint/spm-extras#1.

* fix(cosmoscmd): handle nil start cmd customizer (tendermint/spm#3)

* feat(cmd): add config command (tendermint/spm#4)

* chore: add codeowners file (tendermint/spm#5)

* fix(cosmoscmd): detecting home (tendermint/spm#8)

* feat(testutil): add `testutil` pkg to generate sample objects (tendermint/spm#10)

* add testutil pkg to generate sample objects

* add unit test

* feat: upgrade sdk to v0.44.0 (tendermint/spm#13)

* feat(keeper): add`ibckeeper` okg with static methods to avoid scaffold it (tendermint/spm#12)

* creates a new IBC Keeper with static methods to avoid scaffold it

* remove unused parameters

* update ibc keeper to v0.44

* export interface keepers

* fix(cosmoscmd): remove `vesting` from tx command (tendermint/spm#14)

* remove vesting

* Remove additional line break

* feat: add CI tests (tendermint/spm#15)

* add ci test

* remove test coverage

* fix(cosmoscmd): home flag parsing in sdk v0.44.3 (tendermint/spm#16)

* fix(cosmoscmd): home flag parsing in sdk v0.44.3

* bump ibc version

* feat: add ability to change environment variables prefix (tendermint/spm#23)

* fix(cosmoscmd): cli default outputs (tendermint/spm#22)

* docs(tutorials): blog-index-update (tendermint/spm#1961)

* feat(template): add `--no-simulation` flag (tendermint/spm#1938)

* add no simulation flag

* add no simulation flag to scaffold message command

* move the simulation modifier function to inside the no simulation condition

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>

* fix merge

* fix pkg names

* use rename import for openapiconsole

* fix lint

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Danilo Pantani <danpantani@gmail.com>
Co-authored-by: Jorge Hernández <3452489+jhernandezb@users.noreply.github.com>
Co-authored-by: Aliasgar Merchant <44069404+alijnmerchant21@users.noreply.github.com>
ilgooz added a commit to ignite/cli that referenced this pull request Jan 6, 2022
@ilgooz @lumtis
@Pantani @jhernandezb @alijnmerchant21
chore: merge tendermint/spm/* into starport/pkg (#1968)
3d6f219 
* init & add openapiconsole pkg

* feat: add cosmoscmd package (tendermint/spm#1)

* go mod init =

* genaccounts

* genwasm

* Cosmos app

* Encoding

* Prefix

* gosum

* Init gitignore

* root

* Make types public

* add imports

* Organize imports

* Lint

* Rename to cosmoscmd

* Simplification

* Remove blank line

* refactor: moved wasm logic to tendermint/spm-extras (tendermint/spm#2)

tendermint/spm-extras#1.

* fix(cosmoscmd): handle nil start cmd customizer (tendermint/spm#3)

* feat(cmd): add config command (tendermint/spm#4)

* chore: add codeowners file (tendermint/spm#5)

* fix(cosmoscmd): detecting home (tendermint/spm#8)

* feat(testutil): add `testutil` pkg to generate sample objects (tendermint/spm#10)

* add testutil pkg to generate sample objects

* add unit test

* feat: upgrade sdk to v0.44.0 (tendermint/spm#13)

* feat(keeper): add`ibckeeper` okg with static methods to avoid scaffold it (tendermint/spm#12)

* creates a new IBC Keeper with static methods to avoid scaffold it

* remove unused parameters

* update ibc keeper to v0.44

* export interface keepers

* fix(cosmoscmd): remove `vesting` from tx command (tendermint/spm#14)

* remove vesting

* Remove additional line break

* feat: add CI tests (tendermint/spm#15)

* add ci test

* remove test coverage

* fix(cosmoscmd): home flag parsing in sdk v0.44.3 (tendermint/spm#16)

* fix(cosmoscmd): home flag parsing in sdk v0.44.3

* bump ibc version

* feat: add ability to change environment variables prefix (tendermint/spm#23)

* fix(cosmoscmd): cli default outputs (tendermint/spm#22)

* docs(tutorials): blog-index-update (tendermint/spm#1961)

* feat(template): add `--no-simulation` flag (tendermint/spm#1938)

* add no simulation flag

* add no simulation flag to scaffold message command

* move the simulation modifier function to inside the no simulation condition

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>

* fix merge

* fix pkg names

* use rename import for openapiconsole

* fix lint

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Danilo Pantani <danpantani@gmail.com>
Co-authored-by: Jorge Hernández <3452489+jhernandezb@users.noreply.github.com>
Co-authored-by: Aliasgar Merchant <44069404+alijnmerchant21@users.noreply.github.com>
ilgooz added a commit to ignite/cli that referenced this pull request Jan 6, 2022
@ilgooz @lumtis
@Pantani @jhernandezb @alijnmerchant21
chore: merge tendermint/spm/* into starport/pkg (#1968)
99ad8c3 
* init & add openapiconsole pkg

* feat: add cosmoscmd package (tendermint/spm#1)

* go mod init =

* genaccounts

* genwasm

* Cosmos app

* Encoding

* Prefix

* gosum

* Init gitignore

* root

* Make types public

* add imports

* Organize imports

* Lint

* Rename to cosmoscmd

* Simplification

* Remove blank line

* refactor: moved wasm logic to tendermint/spm-extras (tendermint/spm#2)

tendermint/spm-extras#1.

* fix(cosmoscmd): handle nil start cmd customizer (tendermint/spm#3)

* feat(cmd): add config command (tendermint/spm#4)

* chore: add codeowners file (tendermint/spm#5)

* fix(cosmoscmd): detecting home (tendermint/spm#8)

* feat(testutil): add `testutil` pkg to generate sample objects (tendermint/spm#10)

* add testutil pkg to generate sample objects

* add unit test

* feat: upgrade sdk to v0.44.0 (tendermint/spm#13)

* feat(keeper): add`ibckeeper` okg with static methods to avoid scaffold it (tendermint/spm#12)

* creates a new IBC Keeper with static methods to avoid scaffold it

* remove unused parameters

* update ibc keeper to v0.44

* export interface keepers

* fix(cosmoscmd): remove `vesting` from tx command (tendermint/spm#14)

* remove vesting

* Remove additional line break

* feat: add CI tests (tendermint/spm#15)

* add ci test

* remove test coverage

* fix(cosmoscmd): home flag parsing in sdk v0.44.3 (tendermint/spm#16)

* fix(cosmoscmd): home flag parsing in sdk v0.44.3

* bump ibc version

* feat: add ability to change environment variables prefix (tendermint/spm#23)

* fix(cosmoscmd): cli default outputs (tendermint/spm#22)

* docs(tutorials): blog-index-update (tendermint/spm#1961)

* feat(template): add `--no-simulation` flag (tendermint/spm#1938)

* add no simulation flag

* add no simulation flag to scaffold message command

* move the simulation modifier function to inside the no simulation condition

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>

* fix merge

* fix pkg names

* use rename import for openapiconsole

* fix lint

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Danilo Pantani <danpantani@gmail.com>
Co-authored-by: Jorge Hernández <3452489+jhernandezb@users.noreply.github.com>
Co-authored-by: Aliasgar Merchant <44069404+alijnmerchant21@users.noreply.github.com>
tbruyelle pushed a commit to tbruyelle/cli-diet that referenced this pull request Oct 17, 2022
@ilgooz
chore: merge tendermint/spm/* into starport/pkg (#1968)
84d50a5 
* init & add openapiconsole pkg

* feat: add cosmoscmd package (tendermint/spm#1)

* go mod init =

* genaccounts

* genwasm

* Cosmos app

* Encoding

* Prefix

* gosum

* Init gitignore

* root

* Make types public

* add imports

* Organize imports

* Lint

* Rename to cosmoscmd

* Simplification

* Remove blank line

* refactor: moved wasm logic to tendermint/spm-extras (tendermint/spm#2)

tendermint/spm-extras#1.

* fix(cosmoscmd): handle nil start cmd customizer (tendermint/spm#3)

* feat(cmd): add config command (tendermint/spm#4)

* chore: add codeowners file (tendermint/spm#5)

* fix(cosmoscmd): detecting home (tendermint/spm#8)

* feat(testutil): add `testutil` pkg to generate sample objects (tendermint/spm#10)

* add testutil pkg to generate sample objects

* add unit test

* feat: upgrade sdk to v0.44.0 (tendermint/spm#13)

* feat(keeper): add`ibckeeper` okg with static methods to avoid scaffold it (tendermint/spm#12)

* creates a new IBC Keeper with static methods to avoid scaffold it

* remove unused parameters

* update ibc keeper to v0.44

* export interface keepers

* fix(cosmoscmd): remove `vesting` from tx command (tendermint/spm#14)

* remove vesting

* Remove additional line break

* feat: add CI tests (tendermint/spm#15)

* add ci test

* remove test coverage

* fix(cosmoscmd): home flag parsing in sdk v0.44.3 (tendermint/spm#16)

* fix(cosmoscmd): home flag parsing in sdk v0.44.3

* bump ibc version

* feat: add ability to change environment variables prefix (tendermint/spm#23)

* fix(cosmoscmd): cli default outputs (tendermint/spm#22)

* docs(tutorials): blog-index-update (tendermint/spm#1961)

* feat(template): add `--no-simulation` flag (tendermint/spm#1938)

* add no simulation flag

* add no simulation flag to scaffold message command

* move the simulation modifier function to inside the no simulation condition

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>

* fix merge

* fix pkg names

* use rename import for openapiconsole

* fix lint

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Danilo Pantani <danpantani@gmail.com>
Co-authored-by: Jorge Hernández <3452489+jhernandezb@users.noreply.github.com>
Co-authored-by: Aliasgar Merchant <44069404+alijnmerchant21@users.noreply.github.com>

Former-commit-id: 99ad8c3b629dd799e01b10c821a1f1edd312d020
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@ilgooz @lumtis
@Pantani @jhernandezb @alijnmerchant21
chore: merge tendermint/spm/* into starport/pkg (ignite#1968)
cdc6cd7 
* init & add openapiconsole pkg

* feat: add cosmoscmd package (tendermint/spm#1)

* go mod init =

* genaccounts

* genwasm

* Cosmos app

* Encoding

* Prefix

* gosum

* Init gitignore

* root

* Make types public

* add imports

* Organize imports

* Lint

* Rename to cosmoscmd

* Simplification

* Remove blank line

* refactor: moved wasm logic to tendermint/spm-extras (tendermint/spm#2)

tendermint/spm-extras#1.

* fix(cosmoscmd): handle nil start cmd customizer (tendermint/spm#3)

* feat(cmd): add config command (tendermint/spm#4)

* chore: add codeowners file (tendermint/spm#5)

* fix(cosmoscmd): detecting home (tendermint/spm#8)

* feat(testutil): add `testutil` pkg to generate sample objects (tendermint/spm#10)

* add testutil pkg to generate sample objects

* add unit test

* feat: upgrade sdk to v0.44.0 (tendermint/spm#13)

* feat(keeper): add`ibckeeper` okg with static methods to avoid scaffold it (tendermint/spm#12)

* creates a new IBC Keeper with static methods to avoid scaffold it

* remove unused parameters

* update ibc keeper to v0.44

* export interface keepers

* fix(cosmoscmd): remove `vesting` from tx command (tendermint/spm#14)

* remove vesting

* Remove additional line break

* feat: add CI tests (tendermint/spm#15)

* add ci test

* remove test coverage

* fix(cosmoscmd): home flag parsing in sdk v0.44.3 (tendermint/spm#16)

* fix(cosmoscmd): home flag parsing in sdk v0.44.3

* bump ibc version

* feat: add ability to change environment variables prefix (tendermint/spm#23)

* fix(cosmoscmd): cli default outputs (tendermint/spm#22)

* docs(tutorials): blog-index-update (tendermint/spm#1961)

* feat(template): add `--no-simulation` flag (tendermint/spm#1938)

* add no simulation flag

* add no simulation flag to scaffold message command

* move the simulation modifier function to inside the no simulation condition

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>

* fix merge

* fix pkg names

* use rename import for openapiconsole

* fix lint

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Danilo Pantani <danpantani@gmail.com>
Co-authored-by: Jorge Hernández <3452489+jhernandezb@users.noreply.github.com>
Co-authored-by: Aliasgar Merchant <44069404+alijnmerchant21@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fadeev fadeev Awaiting requested review from fadeev

@Pantani Pantani Awaiting requested review from Pantani

1 more reviewer

@lumtis lumtis lumtis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ilgooz @fadeev @lumtis