update maintainer rules #2307
Merged
update maintainer rules #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shemnon
previously requested changes
May 20, 2021
...re/src/main/java/org/hyperledger/besu/ethereum/core/fees/TransactionGasBudgetCalculator.java
Outdated
Show resolved
Hide resolved
...um/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/PendingTransactions.java
Outdated
Show resolved
Hide resolved
NicolasMassart
dismissed
shemnon’s stale review
it does only impact MD, only a git issue linked to the previous DCO breaking commit, fixed.
Signed-off-by: Nicolas MASSART <nicolas.massart@consensys.net>
NicolasMassart
force-pushed
the
maintainer-rules
branch
from
f689a1b to
0d31624
Compare
This was referenced May 20, 2021
RatanRSur
approved these changes
May 20, 2021
matkt
approved these changes
May 20, 2021
ajsutton
approved these changes
May 20, 2021
jframe
approved these changes
May 20, 2021
lucassaldanha
approved these changes
May 20, 2021
pinges
approved these changes
May 21, 2021
shemnon
approved these changes
May 21, 2021
There was a problem hiding this comment.
Assuming @NicolasMassart is voting in favor, my vote makes it 11.
|
I vote in favour but can't approve my own PR, so absolute majority, no veto, I will merge. |
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Signed-off-by: Nicolas MASSART <nicolas.massart@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
These changes are expected to clarify the rules to reach maintainer status. Some edits were made on the voting process, template PR description added, simplified language,...
The PR also adds a new maintainer type in addition to code maintainer to enable people who significantly contribute to the Besu project to be able to access some project management features such as issues triage and assignation.
Some features, expecially when using Zenhub, indeed require a write access on the repository even though the contributor will not make any code changes. But things like assigning a user to an issue requires maintainer role.
See https://github.com/NicolasMassart/besu/blob/maintainer-rules/MAINTAINERS.md for the easier to read rendered doc.
Approval of this PR
As for the maintainer addition, this PR being a significant change to the process, I require the same rules to be followed:
Fixed Issue(s)
We need significant and fully involved non-code contributors to be able to fully help us on the project without the need to contribute code to become a maintainer.
Changelog