Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vijay Michalik to maintainers #2304

Merged
merged 2 commits into from
May 24, 2021
Merged

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented May 20, 2021

Vijay has helped the Besu project through contributions to user questions, documentation and managing issues on the project.

Voting ends 2 weeks from the publication of this PR.

For more information on this process see the Becoming a Maintainer section in the MAINTAINERS.md file.

Approval of this PR

As for the maintainer addition, this PR being a significant change to the process, I require the same rules to be followed:

  • 2 weeks voting period (ends June 3rd 2021)
  • at least 3 approvals
  • no veto
  • absolute majority makes it pass immediately (currently 11 approvals).

Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and I added this PR that may be interesting to review in parallel #2307

@shemnon
Copy link
Contributor

shemnon commented May 20, 2021

From a process perspective #2307 needs to pass first, as without it there is insufficient justification in this PR. Hence I vote block until either #2307 or a similar proposal passes. (to be explicit, if #2307 passes my block is removed).

@macfarla
Copy link
Contributor

@vmichalik has contributed variously and significantly to docs, Rocket Chat and support issues. Additionally triaging and organising GitHub issues.

@NicolasMassart NicolasMassart requested a review from a team May 21, 2021 08:50
Copy link
Member

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NicolasMassart
Copy link
Contributor

Assuming @atoulme is voting in favor, we reached 11 which is the absolute majority.

@NicolasMassart NicolasMassart enabled auto-merge (squash) May 24, 2021 12:12
@NicolasMassart NicolasMassart merged commit e53e5c8 into hyperledger:master May 24, 2021
@atoulme atoulme deleted the vijay branch May 24, 2021 16:42
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.