-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sajida Zouarhi to maintainers #2303
Conversation
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved and I added this PR that may be interesting to review in parallel #2307
As @shemnon I think we can deal with the PRs #2303 #2304 and #2307 in parallel in order to reduce the duration but only merge #2303 and #2304 if #2307 is merged first. #2303 and #2304 need a bit more detail and justifications to me. I know Sajida and Vijay are doing a great work. I work with them. However it's not about convincing colleagues but all other Besu maintainers and make sure we don't bypass rules that we created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Assuming @atoulme is voting in favor, we reached 11 which is the absolute majority. |
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
Signed-off-by: Antoine Toulme antoine@lunar-ocean.com
Sajida has started helping manage Github issues and collaborating with the existing maintainers to help coordinate the development of Besu.
Voting ends 2 weeks from the publication of this PR.
For more information on this process see the Becoming a Maintainer section in the MAINTAINERS.md file.
Approval of this PR