Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Online DPO #1839
Refactor Online DPO #1839
Changes from 1 commit
94353cb
d88ee55
1a45ec4
5a3bd05
aa67767
576c098
c5a1612
e264126
9653edb
798d1d6
6562bc2
7a0c273
7e03124
0f8b1e3
1f0f6b2
ac11b75
2a7abca
a177097
e74646f
c93c81b
ff479e4
f39c61a
e515d0e
0d8ae8c
0641b55
25af762
29a1244
d858b28
4020f41
8d26a51
b1a264a
79082f8
9554c80
e73c66f
e793dde
2d0a8a1
9580a8d
14be7b7
1b7cdcf
e58d473
da70ab0
ced7c98
e14eb43
629b6f1
4459efd
c7680c7
d3d5175
94f142e
5a0b4e9
ddac3b6
031b6de
3e2cfe5
595c07e
518c896
5c9fd95
85c7bd5
2989a68
435bacd
31d684d
8fdbaa4
b369beb
d9c9736
48c449a
238ac5a
3a37e3c
4d73ee3
ba23435
2db55aa
49a7d47
f330c18
a1d9ba3
dfebb9f
4664b05
9b808ca
66ca5bd
3d280b9
2d28ad9
8f28f4f
f936692
55475e4
845c1bc
3ed03a4
a567e77
21104fd
8a033c7
4fd0666
b36dc0e
8db4b71
0e5a23b
4439a9a
35eff1d
a64721d
ae4a1ed
0b6ac0e
dab37dc
bb267fb
6b7d559
56afe56
f78ff61
bc13c33
03ea0af
57eb673
3ea2654
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was previously set as
save_steps
for logging, but I thinklogging_steps
is more intuitiveThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but I think you have to be careful here:
All this to say that I don't know what the best option is here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, I guess for long runs the user can tweak
logging_steps
accordingly. Let's leave it like this for now and work on a fix if issues are opened