-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Online DPO #1839
Refactor Online DPO #1839
Conversation
After this one is merged #1598 we'll probably only need to do trainer = OnlineDPOTrainer(..., judge=OpenAIJudge()) EDIT: The PR has gone in another direction, we'll integrate the judges later. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
I've tested the code works as intended for the TL;DR experiments of 1B and 2.8B and 6.9B:
What is currently not working is the ZeRO-3, which produces a deadlock in the |
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment, otherwise LGTM. Thanks.
This PR refactors the
OnlineDPOTrainer
to have an API that is closer to that of the offlineDPOTrainer
. It also introduces aLogCompletionsCallback
that produces a table of completions on WandB