Add and save job names in Past CI artifacts#19235
Merged
Conversation
ydshieh
commented
Sep 28, 2022
| version: | ||
| required: true | ||
| type: string | ||
| # Use this to control the commit to test against |
Collaborator
Author
There was a problem hiding this comment.
So we can have a control to test against a targe commit. For example, (Patch release: v4.21.2)
|
The documentation is not available anymore as the PR was closed or merged. |
ydshieh
commented
Sep 28, 2022
| rm -rf reports | ||
|
|
||
| - id: set-matrix | ||
| working-directory: /transformers |
Collaborator
Author
There was a problem hiding this comment.
The above changes are some cleaning similar in #19234 to avoid confusion.
ydshieh
commented
Sep 28, 2022
| job_name="Model tests ($matrix_folders, ${{ matrix.machine_type }})" | ||
| echo "$job_name" | ||
| echo "$job_name" > /transformers/reports/${{ matrix.machine_type }}_tests_gpu_${{ matrix.folders }}/job_name.txt | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
This is the main goal of this PR - save job names in the artifacts.
ydshieh
changed the title
LysandreJik
approved these changes
Sep 29, 2022
Member
LysandreJik
left a comment
LysandreJik
left a comment
There was a problem hiding this comment.
Good call, sounds good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In order to ease the fix process for Past CI, it would be very helpful to have links to jobs for the failed tests.
The GitHub API could give a list of jobs and a list of artifacts, but there is no ensured and easy way to get the correspondence between each artifact/job, see jobs here and artifacts here.
Moreover, when the jobs are running, there is no context evn. variable that gives the job run link (or anything helpful to get this information)
However, the list of jobs given by the API contains the job names and the job run page link (given by
html_url).This PR therefore saves the job names in the corresponding test artifacts. Once the past CI is done:
html_urlTo check the effect of this PR, see the contents in the artifacts in this run