Merged
Conversation
ydshieh
commented
Sep 28, 2022
| header = "| no. | error |" | ||
| sep = "|-:|:-|" | ||
| header = "| no. | error | status |" | ||
| sep = "|-:|:-|:-|" |
Collaborator
Author
There was a problem hiding this comment.
Create this new column here, so we don't need to do it manually on Github page.
ydshieh
force-pushed
the
update_past_ci_report_script
branch
from
f1fe8ba to
1e86f62
Compare
ydshieh
commented
Sep 28, 2022
| job_link = job_links.get(job_name, None) | ||
|
|
||
| # A list with elements of the form (line of error, error, failed test) | ||
| result = [x + [y] + [job_link] for x, y in zip(errors, failed_tests)] |
Collaborator
Author
There was a problem hiding this comment.
Combine the information instead of 2 separate lists previously.
Also add job links, so we can go the job run pages in order to see more information about the errors.
|
The documentation is not available anymore as the PR was closed or merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
To make the fix process easier:
errors.json(instead of 2 files) that containsline of error,error,failed testandjob_linktogether for each element. See below.statuscolumn - in order to update the progress.Elements in
errors.jsonlooks now[ "/transformers/src/transformers/configuration_utils.py:642", "OSError: gs555750 is not a valid git identifier (branch name, tag name or commit id) that exists for this model name. Check the model page at 'https://huggingface.co/bigscience/bloom-350m' for available revisions.", "tests/models/bloom/test_modeling_bloom.py::BloomModelTest::test_batch_generation", "https://github.com/huggingface/transformers/actions/runs/3145556680/jobs/5112996392" ],Having a job link attached to each element, so we can click or copy/paste to go the the job run page for the full traceback. However, this information is not available yet.
I will try to obtain them#19235 is for this goal.