Fix confusing working directory in Push CI#19234
Merged
Conversation
ydshieh
commented
Sep 28, 2022
| uses: actions/checkout@v2 | ||
| with: | ||
| fetch-depth: 2 | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
This created another transformers directory (we already have it when using our docker image )
|
The documentation is not available anymore as the PR was closed or merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Let me launch a tiny run to make sure before merge🙏Previously, the job
setup(to prepare the tests to run) in push CI ran onubuntu-latestrunners, and has to clonetransformerswithactions/checkout@v2.In #19054, it is changed to use the docker image (and run on our runner). This is no particular reason for it, just to make the sequence of jobs looks more linear.
But I forgot to change the working directory in #19054. The job still run without failure (as the 2
transformersdirectory exist at the same time), but it looks somehow confusing. This PR is to clean this.